Skip to content

Update Poached for DuckDB 2.0 - #6

Merged
nicosuave merged 1 commit into
mainfrom
duckdb-two
Nov 5, 2026
Merged

nicosuave merged 1 commit into
mainfrom
duckdb-two

Conversation

@nicosuave

Copy link
Copy Markdown
Member

Poached currently targets DuckDB 1.4.x and does not compile against DuckDB 2.0. This updates the extension to v2.0.0 while preserving its SQL functions and deprecated aliases.

  • Migrate parser construction, identifiers, CTE ownership, expression and function-argument accessors, literal conversion, and result-vector APIs.
  • Reserve capacity for list results so table/function name extraction handles batches exceeding one vector's initial capacity.
  • Pin DuckDB and extension-ci-tools, update distribution and release workflows, and stamp local binaries with v2.0.0 metadata.
  • Add regression coverage for qualified names, CTEs, named function arguments, WHERE values, NULLs, large lists, and multi-chunk table results.

Validated on macOS arm64: warning-free C++ syntax check, release build linked against the official DuckDB v2.0.0 static libraries, all 151 assertions across both SQL test cases, and successful loading and querying in the official v2.0.0 CLI. Cross-platform validation is left to GitHub CI.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T22:10:54.706277Z b0fbdf2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@nicosuave
nicosuave merged commit 2bdb07e into main Nov 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant