Repository navigation
Conversation
Collaborator
Author
Contributor
Sketchi Icons PreviewStatus:
|
Contributor
Sketchi Web PreviewStatus:
|
Contributor
Sketchi Eval Harness PreviewStatus:
|
Contributor
Sketchi Excalidraw Workspace PreviewStatus:
|
Contributor
Sketchi Playground / Studio PreviewStatus:
|
This was referenced Oct 10, 2026
…gistry Register sequence as a canonical diagram family with its own Effect Schema contract (ordered participants, chronological messages) instead of a node/edge graph. The renderer, Code Mode build, and Storybook now consume that contract, and renderDiagram dispatches any canonical family. Refs #280
anandpant
force-pushed
the
feat/sequence-canonical
branch
from
October 10, 2026 22:11
21583e0 to
115e4ae
Compare
anandpant
marked this pull request as ready for review
October 10, 2026 22:12
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This was referenced Oct 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
diagram-coreregisterssequenceas a canonical family with its own Effect Schema contract,SequenceDiagram: ordered participants and chronologically ordered messages, acall/returnmessage type, and style defaults. It also addsgetSequenceValidationIssues(duplicate ids, unknown participants, self messages, lifeline id collisions),parseSequenceDiagram, and two maintained fixtures.IntermediateDiagramis now explicitly the node/edge graph IR for flowchart and mindmap (GRAPH_DIAGRAM_TYPES), so atype: "sequence"graph is rejected.CanonicalDiagramSchema,parseCanonicalDiagram, andvalidateCanonicalDiagramcover every family. Asatisfies Record<DiagramTypeValue, …>map makes a registry entry without a contract fail to compile.renderSequenceDiagramtakes the coreSequenceDiagramand validates it with core, so the renderer's own input interface and render-time checks are deleted.renderDiagramdispatches any canonical diagram to its family renderer.GenerationWorkspaceaccepts any canonical diagram, and a newDiagram Types/SequenceStorybook entry renders both sequence fixtures.Why
#280 asks for one typed sequence contract shared by every entry point. This PR adds that contract and moves the renderer and UI onto it. The next PR moves generation and Code Mode validation onto it and deletes their duplicate shapes.
Verification
pnpm nx affected -t typecheck,test --base=origin/main(12 projects)pnpm run check(Oxlint, Oxfmt, lint-rule tests),tools/project-graph.test.tspnpm nx build-storybook diagram-uiRefs #280