Repository navigation
ci: gate lint, formatting, and custom rules through pnpm run check - #364
Merged
Merged
Conversation
This was referenced Oct 10, 2026
Collaborator
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
anandpant
marked this pull request as ready for review
October 10, 2026 18:28
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
anandpant
force-pushed
the
ci/enforce-oxfmt
branch
from
October 10, 2026 21:26
73f7b0c to
9cd49d3
Compare
anandpant
force-pushed
the
style/oxfmt-reformat
branch
from
October 10, 2026 21:26
0fa66c4 to
314d231
Compare
anandpant
force-pushed
the
ci/enforce-oxfmt
branch
from
October 10, 2026 21:36
9cd49d3 to
f77d245
Compare
Contributor
Sketchi Web PreviewStatus:
|
Contributor
Sketchi Icons PreviewStatus:
|
Contributor
Sketchi Eval Harness PreviewStatus:
|
Contributor
Sketchi Excalidraw Workspace PreviewStatus:
|
Contributor
Sketchi Playground / Studio PreviewStatus:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
CI's lint step now runs
pnpm run check, the single authoritative command from #281. It covers type-aware Oxlint,oxfmt --check, and the custom lint-rule tests.Why
format:checkcan only gate CI once the tree is formatted, so this flip follows the reformat in #363. Keeping it out of #363 leaves that PR purely mechanical.Adds
.git-blame-ignore-revswith #363's squash commit (7d7882018270b60cabe920019eee339998d81de2), so blame skips the repo-wide reformat. GitHub's blame view reads the file automatically; locally, rungit config blame.ignoreRevsFile .git-blame-ignore-revs.How it was verified
pnpm run checkpasses on the reformatted tree.git blame --ignore-revs-file .git-blame-ignore-revsattributes reformatted lines to their earlier commits.Refs #281