Repository navigation
Fix test_no_price_is_invented_off_the_store for leftover flag files - #97
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…flag is present The test assumed the flag file would never exist in a dev checkout, but a leftover from a prior packaging run made STORE_BUILD=True and caused unlock_price() to hit the real Microsoft Store API (returning £24.99). Monkeypatch the store flags to False so the test is resilient to flag files on disk. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_no_price_is_invented_off_the_storefails whenapp/resources/store_build.flagexists as an untracked leftover from a priorbuild_msix.pyrun —STORE_BUILDbecomesTrue,unlock_price()hits the real Microsoft Store API, and returns£24.99instead ofNonese.STORE_BUILDandmse.MAS_BUILDtoFalseso the test enforces its assumption rather than relying on the flag file being absentTest plan
pytest tests/test_onboarding_screens.py::test_no_price_is_invented_off_the_storepasses in a clean worktree (no flag file)store_build.flagis present🤖 Generated with Claude Code