[UIK-5869][dropdown] add notice for dropdown - #3187
Open
ilyabrower wants to merge 161 commits into
Open
ilyabrower wants to merge 161 commits into
ilyabrower wants to merge 161 commits into
Conversation
…elements (#3045) ## Changelog ### @semcore/dropdown-menu #### Fixed - `preventFocusByClick` handler - skip draggable elements. <!--- Provide a general summary of your changes in the Title above --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How has this been tested? <!--- Please describe in detail how you tested your changes. --> <!--- For example: --> <!--- I have added unit tests --> <!--- I have added Voice Over tests --> <!--- Code cannot be tested automatically so I have tested it only manually --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [X] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [ ] Nice improve. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality.
…some theme initial fixes (#3057) ## Changelog ### @semcore/button #### Changed - Styles #### Break - Remove legacy `secondary` `info` theme. ### @semcore/theme #### Changed - Values for color variables - Default height for controls: for M — from 28 to 32. for L — from 40 to 44 ### @semcore/link #### Changed - Styles ### @semcore/modal #### Fixed - Hardcoded margins in Close button. ### @semcore/fullscreen-modal #### Fixed - Hardcoded margins in Close button. ## Motivation and Context **Along with button styles and values for its variables, I had to:** - update comments in some components according to the new variables names we were discussing with girls - remove hardcoded margins in Close button component inside the Modal and FullscreModal - remove hardcoded values for w and h in: BaseTrigger, ColorPicker, InputTags, Input, Notice.Label, Pills, TabLine, TimePicker - updated variables' values and styles of the Link ## How has this been tested? Manually. ## Screenshots (if appropriate): Current: <img width="831" height="477" alt="image" src="https://github.com/user-attachments/assets/d59b0010-13e1-404b-88bc-8de25be28d94" /> Updated: <img width="1024" height="524" alt="image" src="https://github.com/user-attachments/assets/ffcdb9ab-5d09-4821-9d69-87601376f362" /> ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [x] Nice improve. ## Checklist: - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality. --------- Co-authored-by: Valeryia Zimnitskaya <valeryia.zimnitskaya@semrush.com> Co-authored-by: ilia.brauer <ilia.brauer@semrush.com>
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How has this been tested? <!--- Please describe in detail how you tested your changes. --> <!--- For example: --> <!--- I have added unit tests --> <!--- I have added Voice Over tests --> <!--- Code cannot be tested automatically so I have tested it only manually --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [ ] Nice improve. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality.
## Motivation and Context Updated styles for: - Input - InputNumber - InlineInput - TimePicker Updated: - Button's width and max-width - Link's border-radius to round it's focus outline - A bunch of stories to align them with design requirements ## How has this been tested? Manually. ## Screenshots (if appropriate): ### InlineInput before: <img width="354" height="123" alt="image" src="https://github.com/user-attachments/assets/826125fc-82df-4038-b475-ae304f0d559f" /> <img width="464" height="131" alt="image" src="https://github.com/user-attachments/assets/f8fc06f0-329e-48d4-91fa-f64b63b6709a" /> ### InlineInput after: <img width="318" height="132" alt="image" src="https://github.com/user-attachments/assets/0fad9b3c-03ec-4d9c-974a-aec6bd1a392a" /> <img width="315" height="127" alt="image" src="https://github.com/user-attachments/assets/2114eb5e-ee93-42d1-938d-522acaf7035d" /> ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [x] Nice improve. ## Checklist: - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality. --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Slizhevsky Vladislav <uladzislau.slizheuski@semrush.com> Co-authored-by: ilia.brauer <ilia.brauer@semrush.com> Co-authored-by: Valeryia Zimnitskaya <valeryia.zimnitskaya@semrush.com>
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How has this been tested? <!--- Please describe in detail how you tested your changes. --> <!--- For example: --> <!--- I have added unit tests --> <!--- I have added Voice Over tests --> <!--- Code cannot be tested automatically so I have tested it only manually --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [x] Nice improve. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality. --------- Co-authored-by: ilia.brauer <ilia.brauer@semrush.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Sheila Sheikh <166654065+sheila-semrush@users.noreply.github.com> Co-authored-by: Valeryia Zimnitskaya <valeryia.zimnitskaya@semrush.com>
…les-to-theme' into UIK-5641/notice-redesign
<!--- Provide a general summary of your changes in the Title above --> ## Motivation and Context `Divider` rebranding. ## How has this been tested? <!--- Please describe in detail how you tested your changes. --> <!--- For example: --> <!--- I have added unit tests --> <!--- I have added Voice Over tests --> <!--- Code cannot be tested automatically so I have tested it only manually --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [ ] Nice improve. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality. --------- Co-authored-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com> Co-authored-by: Sheila Sheikh <166654065+sheila-semrush@users.noreply.github.com>
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How has this been tested? <!--- Please describe in detail how you tested your changes. --> <!--- For example: --> <!--- I have added unit tests --> <!--- I have added Voice Over tests --> <!--- Code cannot be tested automatically so I have tested it only manually --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [x] Nice improve. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality. --------- Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com> Signed-off-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com> Co-authored-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com>
<!--- Provide a general summary of your changes in the Title above --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How has this been tested? <!--- Please describe in detail how you tested your changes. --> <!--- For example: --> <!--- I have added unit tests --> <!--- I have added Voice Over tests --> <!--- Code cannot be tested automatically so I have tested it only manually --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [ ] Nice improve. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality. --------- Signed-off-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com> Co-authored-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com> Co-authored-by: Sheila Sheikh <166654065+sheila-semrush@users.noreply.github.com>
<!--- Provide a general summary of your changes in the Title above --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How has this been tested? <!--- Please describe in detail how you tested your changes. --> <!--- For example: --> <!--- I have added unit tests --> <!--- I have added Voice Over tests --> <!--- Code cannot be tested automatically so I have tested it only manually --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue). - [ ] New feature (non-breaking change which adds functionality). - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). - [ ] Nice improve. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have updated the documentation accordingly. - [ ] I have added new tests on added of fixed functionality. --------- Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com> Signed-off-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com> Co-authored-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com> Co-authored-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com> Co-authored-by: Sheila <166654065+sheila-semrush@users.noreply.github.com>
…5869/notice-for-dropdown
ilyabrower
requested review from
Valeria-Zimnitskaya and
slizhevskyv-semrush
September 11, 2026 11:44
Base automatically changed from
UIK-5351/add-more-variables-to-theme
to
release/v18
September 11, 2026 17:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: