Fix real-server CI environment and registry reuse - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tradeoffs
Separating server lookup from installer lookup preserves the guarantee that --download exercises Mason even when the runner contains a same-named server proxy. It introduces one internal environment channel between the E2E harness and Mason installers; new installer subprocesses must use the shared installer-command helper. Sharing an artifact adds a small upload/download cost while eliminating per-shard registry discovery and reducing rate-limit exposure.
Validation
The complete make test target reaches cargo deny and then fails on the existing rustls 0.23.40 advisory RUSTSEC-2026-0285. The advisory requires rustls 0.23.45 or newer and is unrelated to this patch.