Remove coq-lsp and exclude unsupported Mason backends - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on segoon/lsp-cli-data#7. Merge that PR with a merge commit so submodule commit 8615ebd6d13487114222386fe395ad7707f872ed remains reachable.
Root cause
The E2E planner resolved every server marked downloadable against the current Mason registry. coq_lsp uses pkg:opam, but lsp-cli supports only cargo, generic, github, golang, npm, nuget, and pypi. Auditing the full inventory exposed additional unsupported backends and two packages no longer categorized as LSP packages.
Decisions and tradeoffs
Validation