Repository navigation
Portrait mode: a third capture mode with the background blurred from depth - #271
Merged
Merged
Conversation
Contributor
📊 Test Coverage Report✅ 796/820 tests passed · ⏭️ 24 skipped
🎥 Capture & session core
📁 Full report — 103 files
Generated from |
darioalessandro
marked this pull request as ready for review
November 9, 2026 06:19
…depth The director shows PHOTO / PORTRAIT / VIDEO when every camera in the rig reports supports_portrait; one camera that can't (older build, single-lens phone, Mac, front wide camera) hides the tab and drops the rig to Photo. Wire: RecordingModeEnum.Portrait = 4 and CameraState.supports_portrait. No new commands; SetCameraMode carries the mode. Camera: Portrait is the photo format plus depth and person-matte delivery, capped at 12MP. The blur is baked by CIDepthBlurEffect at f/4.5 and the still is cropped and encoded like any other. Shutter paths keep a still mode instead of forcing Photo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
darioalessandro
force-pushed
the
portrait-mode
branch
from
November 9, 2026 06:24
a4f8450 to
52b5e78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portrait comes to Remote Shutter as a third mode on the remote, next to Photo, the way Apple's Camera does it. People already know what it means, so there's nothing new to learn.
What you get
.Photo, which would have turned depth off right before the shot.Wire changes
RecordingModeEnum.Portrait = 4CameraState.supports_portrait: bool: the active camera delivers depth. It moves with device swaps. Old peers don't send it, so they read as unsupported and never see mode 4.SetCameraModealready carries the mode.Not in this PR
Verified
CaptureIntegrationTests: 16 of 17 pass, including the 4K30 gate and the newtestPortraitStillIsBlurredWithin12MPAndFramesKeepFlowing. Depth and the matte turn on, the zoom range stays 1.0–189, the still comes back at 4032×3024 and re-rendered by the blur, and frames flow both ways.testExposureProbeAppliesAndReportsTruth, fails the same way on unchanged master. It's a pre-existing crash: manual exposure on the 18 Pro throwsNSInvalidArgumentExceptionbecause its lens aperture is adjustable. Separate fix.Not verified yet (why this is a draft)
🤖 Generated with Claude Code