Repository navigation
Import the package as diskcache_community so it installs next to upstream diskcache instead of overwriting it - #22
Merged
Conversation
Documentation build overview
7 files changed ·
|
…ream diskcache instead of overwriting it.
avgvi
force-pushed
the
feat/separate-import-name
branch
from
October 18, 2026 19:14
b3f1248 to
6637c73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the package from
diskcache/todiskcache_community/, so diskcache-community installs next to the upstreamdiskcachedistribution instead of overwriting its files. A project can now move to the fork while another dependency in the same environment still requiresdiskcache, which the shared package directory made impossible. The public API, thecache.dbschema, the file layout and the serialization are unchanged, so cache directories are still shared with 5.6.3 in both directions.git mv diskcache diskcache_community;pyproject.toml,tox.ini, the release workflow, the tests, the docstrings and the docs importdiskcache_community, and Sphinx cross-references point at the new module paths. Django settings namediskcache_community.DjangoCacheanddiskcache_community.SafeDisk.diskcachedist-info next to the fork is removed, since the folders no longer collide;tests/test_init.pynow checks the package identity and, when upstream is installed, that both import side by side and read each other's caches.tests/golden/verify.pyandmake_fixtures.pyusediskcache_communityunder pytest and the upstream wheel when run as scripts, so the golden tests still run in both directions.coexistjob installs the fork anddiskcache==5.6.3together, runs the coexistence and golden tests with the reverse direction enabled, and checks that uninstalling either distribution leaves the other importable.SafeDiskthe default, since it stays opt-in.This is the base of #23, #24 and #25.
Verified: 397 tests pass on Python 3.12 with Django 4.2, including the golden tests in both directions against a 5.6.3 environment and the coexistence test with upstream installed; the
coexistjob's steps pass in a fresh environment; blue, isort, flake8, mypy, doc8 and the Sphinx build with warnings as errors pass, and pylint reports what it reports onmaster.