Skip to content

Synchronized with the latest API changes - #18

Merged
burgaard merged 12 commits into
mainfrom
2026-10-31-api-sync
Nov 1, 2026
Merged

burgaard merged 12 commits into
mainfrom
2026-10-31-api-sync

Conversation

@burgaard

Copy link
Copy Markdown
Contributor

No description provided.

@burgaard burgaard left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review (high effort). Inline comments below, plus one finding on a line outside the diff:

  • README.md:130: still says known versions run "V2026_07_01 through V2026_10_21". This PR adds V2026_10_28 and moves Latest to it, so the range is now one version short. It should read through V2026_10_28.

Comment thread src/types.ts Resolved
Comment thread src/types.ts Resolved
Comment thread src/client.ts Resolved
Comment thread src/types.ts Resolved
Comment thread src/types.ts Resolved
Comment thread src/types.ts Resolved
Comment thread src/types.ts Resolved
@burgaard

Copy link
Copy Markdown
Contributor Author

On the review summary:

Review body (README.md:130, known-versions range)

Fixed: the range now reads V2026_07_01 through V2026_10_28.

Kim Burgaard added 4 commits October 30, 2026 23:32
…19cd

aea19cd Updated skills

git-subtree-dir: .claude/skills/seclai-changelog
git-subtree-split: aea19cd492abe95322e1066cee228c529b9e2db4
5b4e063 Updated skills
14a086e Addressed review comments
4a9410f Addressed review comments
683ba85 Addressed review comments
f16043e Addressed review comments
9f5a04b More audit tool fixes
20f845d Addressed review comments
77cecda Updated the audit-tool

git-subtree-dir: .claude/skills/seclai-sdk-sync
git-subtree-split: 5b4e0631ddc4763967fcb2bf25c1623709a7e3dd

@burgaard burgaard left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review of HEAD~1..HEAD (local 8233755, the subtree update of .claude/skills/seclai-sdk-sync/). The commit isn't pushed yet (the PR head is c04a612), so none of these lines are in the PR diff. All findings are listed here instead of as inline comments.

  1. sdksync.py:1300 (classify_change): a change that only reformats the parameter list is graded BREAKING. public_surface stores norm(params) verbatim, so a trailing comma added when prettier wraps a signature ((a: string) → (\n a: string,\n)) makes old_par != new_par. split_args gives identical lists, so _ts_compatible_change returns None (old == new), added_optional is False, and the result is ("break", "parameter list changed"). I confirmed this with classify_change('javascript', ('R','a: string'), ('R','a: string,')). surface then exits 1. Compare the split lists, not the raw strings, before grading.
  2. sdksync.py:305 (strip_comments): a JS regex literal is read as a comment. In /^image\/*/ the /* opens a block comment that runs to the next */ anywhere in the file. Every method signature in between disappears from the surface and is reported REMOVED. // inside a regex like /https?:\/\// cuts off the rest of the line the same way.
  3. sdksync.py:1112 (altitude): comments are now stripped before the parameter list is sliced, but only in surface. return_type (around line 990, used by returns) still runs balanced_slice(body, open_paren, "(", ")") on raw text, so a ) in a parameter comment (// (default: 2000)) still ends the list early there. The two functions repeat the same slice-the-parameters-then-match-the-tail logic. A single shared helper that strips comments would fix both.
  4. sdksync.py:1235 (_ts_wrapped_type): balanced_slice(rest_n, ..., "<", ">") counts the > of => as a closer. split_args got this fix in the same change, but balanced_slice did not. Wrapping a type that contains an arrow function, such as Omit<{ cb: () => void }, "a">, truncates inner and is graded BREAKING instead of WARN (confirmed).
  5. sdksync.py:1157 (_ts_object_members): members split only on ; or ,. TypeScript also allows members separated only by newlines ({\n a?: string\n b?: number\n}). Those collapse into one "member" named a, so adding an optional member is graded BREAKING (confirmed), and the member text compared is wrong.
  6. sdksync.py:342 (split_args): only the > of => is exempt from closing a bracket. A comparison in a default value (a = n >= 0, b: number) drops the depth to -1, so later commas never split and the arity is wrong. split_args('a = 1 >= 0, b: number') returns one entry.
  7. sdksync.py:1175 (_ts_union): the | split happens at depth 0 after an arrow, so cb?: (e: E) => T → cb?: (e: E) => T | undefined is labelled "optional property widened to accept undefined". What actually changed is the callback's return type. The grade (WARN) happens to be right, but the label misdescribes the change.
  8. sdksync.py:1163 (reuse): the member regex in _ts_object_members repeats _TS_MEMBER_RE, which is defined just below it. The header regex at 1227 repeats _ts_inline_object's. " ".join(x.split()) is written out about 6 times, including the local norm lambda at 1249, while public_surface has its own norm. A module-level _norm and a single member regex would do.
  9. sdksync.py:113 (efficiency): the JS boundary_re is the same pattern as helper_re, so endpoint_helpers scans the file twice with the same regex for its ends set. The set removes the duplicates, but the second scan is wasted. Dedup the patterns before scanning.
  10. SKILL.md:326: "needs #minor in a commit message (not the PR title)" says the PR title doesn't work, but it does. A squash merge uses the PR title as the commit subject, and github-tag-action reads that too. The 1.7.0 bump came from #minor in the squashed commit list (703c779), but a #minor in the PR title would also have worked. Suggest "in the PR title or a commit message".

Kim Burgaard added 5 commits October 30, 2026 23:50
…b9d6

0f1b9d6 Updated skills and guards

git-subtree-dir: .claude/skills/seclai-changelog
git-subtree-split: 0f1b9d67b07b47b69cab19d9ade3fe62687b53a2
f6aa6eb Updated skills and guards

git-subtree-dir: .claude/skills/seclai-sdk-sync
git-subtree-split: f6aa6ebc8a8457cb4b2535e41ee0d1258647d422
@burgaard
burgaard merged commit 03087b0 into main Nov 1, 2026
1 check passed
@burgaard
burgaard deleted the 2026-10-31-api-sync branch November 1, 2026 03:30
@burgaard burgaard mentioned this pull request Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant