Repository navigation
Synchronized with the latest API changes - #18
Merged
Merged
Conversation
burgaard
commented
Oct 31, 2026
burgaard
left a comment
Contributor
Author
There was a problem hiding this comment.
Code review (high effort). Inline comments below, plus one finding on a line outside the diff:
- README.md:130: still says known versions run "
V2026_07_01throughV2026_10_21". This PR addsV2026_10_28and movesLatestto it, so the range is now one version short. It should readthrough V2026_10_28.
Contributor
Author
|
On the review summary: Review body (README.md:130, known-versions range)Fixed: the range now reads |
added 4 commits
October 30, 2026 23:32
…19cd aea19cd Updated skills git-subtree-dir: .claude/skills/seclai-changelog git-subtree-split: aea19cd492abe95322e1066cee228c529b9e2db4
5b4e063 Updated skills 14a086e Addressed review comments 4a9410f Addressed review comments 683ba85 Addressed review comments f16043e Addressed review comments 9f5a04b More audit tool fixes 20f845d Addressed review comments 77cecda Updated the audit-tool git-subtree-dir: .claude/skills/seclai-sdk-sync git-subtree-split: 5b4e0631ddc4763967fcb2bf25c1623709a7e3dd
burgaard
commented
Oct 31, 2026
burgaard
left a comment
Contributor
Author
There was a problem hiding this comment.
Code review of HEAD~1..HEAD (local 8233755, the subtree update of .claude/skills/seclai-sdk-sync/). The commit isn't pushed yet (the PR head is c04a612), so none of these lines are in the PR diff. All findings are listed here instead of as inline comments.
sdksync.py:1300(classify_change): a change that only reformats the parameter list is graded BREAKING.public_surfacestoresnorm(params)verbatim, so a trailing comma added when prettier wraps a signature ((a: string)→(\n a: string,\n)) makesold_par != new_par.split_argsgives identical lists, so_ts_compatible_changereturns None (old == new),added_optionalis False, and the result is("break", "parameter list changed"). I confirmed this withclassify_change('javascript', ('R','a: string'), ('R','a: string,')).surfacethen exits 1. Compare the split lists, not the raw strings, before grading.sdksync.py:305(strip_comments): a JS regex literal is read as a comment. In/^image\/*/the/*opens a block comment that runs to the next*/anywhere in the file. Every method signature in between disappears from the surface and is reported REMOVED.//inside a regex like/https?:\/\//cuts off the rest of the line the same way.sdksync.py:1112(altitude): comments are now stripped before the parameter list is sliced, but only insurface.return_type(around line 990, used byreturns) still runsbalanced_slice(body, open_paren, "(", ")")on raw text, so a)in a parameter comment (// (default: 2000)) still ends the list early there. The two functions repeat the same slice-the-parameters-then-match-the-tail logic. A single shared helper that strips comments would fix both.sdksync.py:1235(_ts_wrapped_type):balanced_slice(rest_n, ..., "<", ">")counts the>of=>as a closer.split_argsgot this fix in the same change, butbalanced_slicedid not. Wrapping a type that contains an arrow function, such asOmit<{ cb: () => void }, "a">, truncatesinnerand is graded BREAKING instead of WARN (confirmed).sdksync.py:1157(_ts_object_members): members split only on;or,. TypeScript also allows members separated only by newlines ({\n a?: string\n b?: number\n}). Those collapse into one "member" nameda, so adding an optional member is graded BREAKING (confirmed), and the member text compared is wrong.sdksync.py:342(split_args): only the>of=>is exempt from closing a bracket. A comparison in a default value (a = n >= 0, b: number) drops the depth to -1, so later commas never split and the arity is wrong.split_args('a = 1 >= 0, b: number')returns one entry.sdksync.py:1175(_ts_union): the|split happens at depth 0 after an arrow, socb?: (e: E) => T→cb?: (e: E) => T | undefinedis labelled "optional property widened to accept undefined". What actually changed is the callback's return type. The grade (WARN) happens to be right, but the label misdescribes the change.sdksync.py:1163(reuse): the member regex in_ts_object_membersrepeats_TS_MEMBER_RE, which is defined just below it. The header regex at 1227 repeats_ts_inline_object's." ".join(x.split())is written out about 6 times, including the localnormlambda at 1249, whilepublic_surfacehas its ownnorm. A module-level_normand a single member regex would do.sdksync.py:113(efficiency): the JSboundary_reis the same pattern ashelper_re, soendpoint_helpersscans the file twice with the same regex for itsendsset. Thesetremoves the duplicates, but the second scan is wasted. Dedup the patterns before scanning.SKILL.md:326: "needs#minorin a commit message (not the PR title)" says the PR title doesn't work, but it does. A squash merge uses the PR title as the commit subject, andgithub-tag-actionreads that too. The 1.7.0 bump came from#minorin the squashed commit list (703c779), but a#minorin the PR title would also have worked. Suggest "in the PR title or a commit message".
added 5 commits
October 30, 2026 23:50
…b9d6 0f1b9d6 Updated skills and guards git-subtree-dir: .claude/skills/seclai-changelog git-subtree-split: 0f1b9d67b07b47b69cab19d9ade3fe62687b53a2
f6aa6eb Updated skills and guards git-subtree-dir: .claude/skills/seclai-sdk-sync git-subtree-split: f6aa6ebc8a8457cb4b2535e41ee0d1258647d422
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.