Skip to content

2026 10 21 api sync - #17

Merged
burgaard merged 16 commits into
mainfrom
2026-10-21-api-sync
Oct 22, 2026
Merged

burgaard merged 16 commits into
mainfrom
2026-10-21-api-sync

Conversation

@burgaard

Copy link
Copy Markdown
Contributor

No description provided.

Kim Burgaard added 3 commits October 21, 2026 09:18
b62c912 Updated tools

git-subtree-dir: .claude/skills/seclai-sdk-sync
git-subtree-split: b62c912a31a9a89ae5e398ef193e7cf064a09895
Add setAcceptedAttachments, listContentAttachments, getContentAttachment,
listContentAttachmentEmbeddings, downloadContentAttachment and
listEmailSourceRejections; regenerate types; add SeclaiApiVersion
constants 2026-10-05..2026-10-19 and move Latest to 2026-10-19. Keep
server-defaulted include_reasoning and accepted-attachment slot min
optional on request types. README and CHANGELOG (1.7.0) updated.
Comment thread README.md Resolved
Comment thread CHANGELOG.md Resolved
Comment thread CHANGELOG.md Resolved
Comment thread src/types.ts Resolved
Comment thread tests/client.test.ts Resolved
Comment thread tests/client.test.ts Resolved
Comment thread src/client.ts Resolved

@burgaard burgaard left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review of the last two commits (HEAD~2..HEAD, medium effort). No crash-level bugs; 7 findings inline, most important first.

Comment thread src/types.ts Resolved
Comment thread README.md Resolved
Comment thread tests/client.test.ts Resolved
Comment thread src/client.ts Resolved
Comment thread src/client.ts Resolved
Comment thread src/client.ts Resolved
Comment thread README.md Resolved

@burgaard burgaard left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review (Claude Code, /code-review medium) of commit 5711bc0.

Most of the findings are in the new download() helper in src/client.ts: the listener on the caller's signal is never removed, the timer is only cleared on error, timeouts are indistinguishable from cancels, and timeoutMs isn't validated. Switching to AbortSignal.timeout() + AbortSignal.any() fixes most of them. The README changes match the generated types.

Comment thread src/client.ts Resolved
Comment thread src/client.ts Resolved
Comment thread src/client.ts Resolved
Comment thread src/client.ts Resolved
Comment thread src/client.ts Resolved
Comment thread tests/client.test.ts Resolved

@burgaard burgaard left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review (medium) of the latest commit (HEAD~1..HEAD): no crash-level bugs. The 7 findings below are about API consistency, documentation and test coverage.

Comment thread src/client.ts Resolved
Comment thread src/client.ts Resolved
Comment thread src/client.ts Resolved
Comment thread tests/client.test.ts Resolved
Comment thread tests/client.test.ts Resolved
Comment thread CHANGELOG.md Resolved
Comment thread README.md Resolved
Comment thread src/client.ts Resolved
Comment thread README.md Resolved
Comment thread CHANGELOG.md Resolved

@burgaard burgaard left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the latest commit (HEAD~1..HEAD, docs only). No runtime changes and no correctness bugs. Inline comments cover documentation regressions from replacing the "what signal does" wording with "passed to fetch".

Outside the diff, README.md ~L919 (Cancellation section): it still says AbortSignal support is for "all low-level methods". Now that the inline comments are gone, the README never says that downloadSourceExport(), downloadAgentRunAttachment() and downloadContentAttachment() accept signal, or that it also covers the body stream. A user looking for how to time-limit a download finds only the low-level request example.

Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread src/client.ts Resolved
Comment thread src/client.ts Resolved
Comment thread src/client.ts Resolved
Comment thread CHANGELOG.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread src/client.ts Resolved
Comment thread src/client.ts Resolved
Comment thread CHANGELOG.md Resolved
Comment thread src/client.ts Resolved
Comment thread CHANGELOG.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread src/types.ts Resolved
Comment thread src/types.ts Resolved
Comment thread CHANGELOG.md Resolved
Comment thread src/openapi.ts Resolved
Comment thread src/openapi.ts Resolved
Comment thread tests/client.test.ts Resolved
Comment thread src/types.ts Resolved
Comment thread src/types.ts Resolved
Comment thread src/types.ts Resolved
Comment thread src/types.ts Resolved
Comment thread CHANGELOG.md Resolved
Comment thread CHANGELOG.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
Comment thread CHANGELOG.md Resolved
Comment thread README.md Resolved
Comment thread README.md Resolved
@burgaard
burgaard merged commit 703c779 into main Oct 22, 2026
1 check passed
@burgaard
burgaard deleted the 2026-10-21-api-sync branch October 22, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant