Skip to content

fix: run njit serially in forked children of a non-fork-safe threading layer - #221

Merged
flying-sheep merged 5 commits into
scverse:mainfrom
selmanozleyen:fork-fallback
Sep 28, 2026
Merged

flying-sheep merged 5 commits into
scverse:mainfrom
selmanozleyen:fork-fallback

Conversation

@selmanozleyen

Copy link
Copy Markdown
Member

fixes #179

adds a fallback for unsafe fork cases by detecting forks

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (311f6c1) to head (9b984d1).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #221      +/-   ##
===========================================
+ Coverage   97.92%   100.00%   +2.07%     
===========================================
  Files          21        21              
  Lines         579       592      +13     
===========================================
+ Hits          567       592      +25     
+ Misses         12         0      -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 234 untouched benchmarks


Comparing selmanozleyen:fork-fallback (9b984d1) with main (311f6c1)

Open in CodSpeed

@flying-sheep flying-sheep added the run-gpu-ci Apply this label to run GPU CI once label Sep 25, 2026
Comment thread src/fast_array_utils/numba/__init__.py Outdated
Comment thread src/fast_array_utils/numba/__init__.py

@flying-sheep flying-sheep left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! two questions above.

@flying-sheep
flying-sheep merged commit 77a37eb into scverse:main Sep 28, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-gpu-ci Apply this label to run GPU CI once

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fork() called from a process already using GNU OpenMP, this is unsafe.

2 participants