Repository navigation
Fixture maps' round trip: fields an action does not use are not compared - #34
Merged
Merged
Conversation
…s not use is not the script's Wakka Wakka's Play WAV carries a text the game never reads; the script says only what an action uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018GH4f3irntPPjMWMxC2pgP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixture maps' round-trip test (
tests/script.test.ts) failed on Wakka Wakka. One of its Play WAV actions has text in a field the game never reads for that action, and a script writes only the fields an action uses, so the text doesn't come back.The test now compares an action's text and sound only where that action's definition uses them. Nothing about the language changes.
The test began failing once Wakka Wakka was added to
fixtures/maps. All 40 tests intests/script.test.tspass, andtscis clean.🤖 Generated with Claude Code
https://claude.ai/code/session_018GH4f3irntPPjMWMxC2pgP