Repository navigation
AddDetail renders the bar even when OptionSetVisibility(false) - #247
Open
tsuyukidev wants to merge 1 commit into
Open
tsuyukidev wants to merge 1 commit into
tsuyukidev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #236.
AddDetailcallsrender()when it records the first detail, without checkingconfig.invisible. Every other render entry point checks it first (Add64,Describe,RenderBlank,renderDetails), so an invisible bar stays quiet right up until the firstAddDetail, which then paints a line:Guarding the initial render with
!p.config.invisiblematches the surrounding methods.renderDetails()already returns early when invisible, so the rest of the path was fine.