Correct Windows toolbar destinations and scoped keyboard focus - #453
Merged
coneilen merged 3 commits intoSep 26, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Integrate logical header geometry and physical UIA boundaries into buffered rendering while preserving scoped keyboard focus and merged editor/provider changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct destination-specific toolbar behavior and add explicit, scoped keyboard focus. Both affected parity-ledger rows remain Partial.
Changes
The only shared test-script change adds the required -lgdi32 linkage to the existing JumpPalette test invocation. No live module, shared-gate integration, or provider-pin changes are included.
Evidence
RED: Restore the generic panel transition and inspection-presence-only visibility in production helpers -> tests fail with expected workspace/found project and at the below-threshold worktree-notice assertion.
GREEN: Restore the reviewed helpers and rerun identical tests -> both pass, with pre-mutation source hashes restored.
REGRESSION: Run WindowsShell.Tests.ps1 and the supported shell build using pinned own-worktree dependencies -> pass; 42 executable source suites, including 303 App tests.
These are post-hoc sensitivity controls, not a claim of test-first development. The coordinator independently reviewed the final changes and reran the 303-test app/accessibility suite.
Limitations
Live validation failed at foreground acquisition before UIA root access. No live proof is claimed for UIA SetFocus/reentrant-event completion, F6/Jump activation, rendered focus pixels, sidebar effects, or provider-backed workspace/panel behavior.
The pretranslation tests use an explicit eligibility seam. The hidden-HWND test proves actual Tab accelerator dispatch, not actual header focus delivery.
Deferred live tooling and evidence remain outside this PR. Cross-project worktree-notice aggregation, unsupported summary/board/mailroom panel content, and macOS visual matching remain follow-up work.
Reviewed head: 29ba387.
Commit includes DCO sign-off and Copilot coauthor.