Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: scgopi <scgopireddy@gmail.com>
Pasting a screenshot into the New Node dialog did nothing at all: a SwiftUI `TextField`'s field editor owns ⌘V and can only accept text, so the keystroke landed nowhere and the dialog read as broken. ⌘V and drag-and-drop now take an image, write it beside the node's memory, and put `[image #1]` in the brief where the caret was heading. The picture itself cannot travel — `zmx` starts a session by typing its launch command into a PTY — so the placeholder is swapped for the file's path when the prompt is composed, which is one place both launchers already read. A board carrying words as well as pixels is read as words: copying out of a rich-text editor puts a rendering of the selection beside the text, and eating that paste would lose something the human meant to type. A copied image *file* is unambiguous and wins regardless. Not offered for a loop on another machine, whose ensure dial delivers text, or for a composite, which never opens a session. `ProjectFeature.swift` was at swiftlint's file-length and type-body budgets, so the New Node dialog's own reducer code moves to `ProjectFeature+NodeForm.swift` unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: scgopi <scgopireddy@gmail.com>
scgopi
force-pushed
the
feat/prompt-image-attachments
branch
from
September 20, 2026 18:49
0769bcb to
abc7603
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasting a screenshot into the New Node dialog did nothing at all. A SwiftUI
TextField's field editor owns ⌘V and accepts only text, so the keystroke landed nowhere and the dialog read as broken.What now happens
⌘V or a drag onto the brief field writes the image beside the node's memory (
~/.graphcode/memory/PROJECT/NODE/attachments/) and puts[image #1]in the field. The picture itself can never travel —zmxstarts a session by typing its launch command into a PTY, so a prompt is text on a canonical-mode line — so the placeholder is swapped for the file's path inLoopNode.sessionPrompt, which is the one place both launchers already read. A path is something every backend can open, and three of the five have a flag for it.The draft's id is the node's id (
NodeDraft.id), which is what lets the bytes be filed under their final home before the node exists./goaland/looptake the rest of the line, so a path appended past the predicate would become part of what an evaluator judges.ProjectFeature.swiftsat at swiftlint's file-length and type-body budgets, so the New Node dialog's own reducer code moves toProjectFeature+NodeForm.swiftunchanged — the change does not fit otherwise.Evidence
Rebased onto
e28a1499and re-run from the worktree with a private DerivedData path.RED: xcodebuild test -only-testing:graphcodeTests/PromptAttachmentTests with PromptAttachments.resolving short-circuited to return its input -> exit=65, TEST FAILED, 7 of the new tests fail
GREEN: xcodebuild test -only-testing on the three new suites with resolution restored -> exit=0, TEST SUCCEEDED, all 24 new tests pass and are confirmed individually by name in the log
REGRESSION: xcodebuild -scheme graphcode test, then -scheme graphcode-cli build and -scheme graphcoded build -> exit=0 each, 1920 passed / 0 failed / 0 skipped per the xcresult summary
The 7 that go red without resolution:
aPlaceholderBecomesThePathWhereItStood,eachPlaceholderTakesItsOwnPath,animageTheTextNeverNamedIsStatedAtTheEnd,aPromptThatIsOnlyAnImageIsStillAPrompt,aGoalCarriesThePathInsideTheConditionRatherThanAfterIt,aSketchWhoseNoteIsOnlyAnImageOpensAnyway,aTimedLoopKeepsItsDirectiveAndCarriesThePathIntoTheTask.swiftlint lintswift format lint --recursive --strictThe rebase took main's newer
.goalBasedbranch (the report-done sentence) and itsdraftModelTierdefaults, both kept.Not in this cut
Remote graphs (would need base64 through the ensure script), and the native attach flags where a CLI supports them interactively (
codex -i,piwith an at-prefixed file) — the path in the prompt already covers all five backends, so those are a refinement rather than a foundation. Copilot's--attachmentis non-interactive only and cannot be used at all.🤖 Generated with Claude Code
Gate re-run from the worktree on the rebased branch; the macOS job covers the same suites in CI.