inlet: fix bad_weak_ptr abort during inlet destruction - #289
Open
mscheltienne wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the intermittent
std::bad_weak_ptr→std::terminate/SIGABRTon inlet destruction reported in #220:resolve_attempt_udp::cancel()callsshared_from_this()on an attempt that has no live shared owner, and the exception skips the watchdogjoin(), leaving~inlet_connectionto destroy a joinablestd::thread. #220 was closed by #246, but #246 only fixes the outlet-side garbage-sample bug (consumer_queue.h/tcp_server.cpp) and never touches the inlet resolver-cancellation path, so the crash still reproduces on current main.Those changes have been suggested by Claude (Fable) following digging in a CI failure on mne-tools/mne-lsl#565. This changes are outside my expertise and comfort zone, thus up to you to merge or iterate on those changes.