feat: propagate error categories to SGP spans - #486
Open
jshaikScale wants to merge 2 commits into
Open
Conversation
Capture ADK failures and preserve producer ownership metadata so SGP can distinguish application, platform, and unknown errors. Co-authored-by: Cursor <cursoragent@cursor.com>
Provide typed application and platform error classes with documented ownership boundaries instead of relying on arbitrary exception attributes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApplicationErrorandPlatformErrorownership markers with documented boundariesunknownerror_categorymetadata alongside SGPstatus=ERROR, while remaining compatible with legacy recordsTest plan
.venv/bin/pytest -n 0 tests/lib/core/tracing/test_span_error.py tests/lib/adk/test_tracing_module.py tests/lib/core/tracing/processors/test_sgp_tracing_processor.py(65 passed)Greptile Summary
Adds categorized span-error propagation across ADK tracing and SGP telemetry.
application,platform, orunknown.error_categorymetadata.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Exception raised in span body] --> B[set_span_error] B --> C[Span data __error__] C --> D[SGP tracing processor] D --> E[SGP status ERROR] D --> F[error_category metadata] B --> G[Original exception re-raised]Reviews (2): Last reviewed commit: "fix: make error ownership classification..." | Re-trigger Greptile