Repository navigation
decide: an incident-fix decision to fix names its ticket id - #221
Merged
Merged
Conversation
ticket add takes a fix ticket only from an incident-fix decision whose refs name both the incident and the ticket, and an owner's answer approves one decision. A decision that named only the incident (stacks, 2026-11-13, stacks-213) couldn't be used for the ticket, and replacing it meant asking the owner the same question again. decide now refuses a fix decision without a ticket id in --refs, saying why; "watch …" or "ignore …" decisions need none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Reviewed:
Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A supervisor lesson on a cloud box (stacks, candidate k-20261113-062934246) holds for any project.
ticket addaccepts a fix ticket only from an incident-fix decision whose refs name both the incident and the ticket, and an owner's answer approves one decision. On 2026-11-13 (stacks-213), a decision named only the incident. It couldn't be used for the ticket, and replacing it meant asking the owner the same question again, which is exactly the re-asking the owner has been objecting to.What
decide --class incident-fixnow refuses a fix decision whose--refsname no ticket id besides the incident, and says why. Decisions startingwatch …orignore …need no ticket, as supervisor.md §3 shows. Ticket ids are anything that isn't a log id (p-,q-,d-, … with a date).Tested
node --checkonly.test/lib/chain.mjsgains one assertion: a fix decision without its ticket is refused. I didn't runkit.test.mjshere: it's slow, and timing-sensitive on this loaded 4-CPU box. Left to CI.🤖 Generated with Claude Code