Repository navigation
check-ticket: say how to clear "outside touches" after ticket set - #220
Merged
Merged
Conversation
#196 named the fix for a ticket added since the log last landed. The same holds for a ticket the supervisor changed with ticket set (touches, done-whens): the forge checks it as main's log has it, so widened touches fail "changes files outside touches" until log-sync and merge --chore log land the change. A supervisor recorded this twice (stacks-117, stacks-213). The error now says so, and supervisor.md's Merging bullet covers ticket set as well as ticket add. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Reviewed: the hint text and the doc line match the forge reading only main's landed log, and the g1 goldens are updated. No authority change, and CI passes 9 of 9. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A supervisor lesson on a cloud box (stacks, candidate k-20261113-074439233) holds for any project.
check-prandmergeread tickets from main's landed log. Afterticket setwidens a ticket's touches, the forge still sees the old touches, and the PR failschanges files outside touchesuntillog-syncandmerge --chore logland the change. That happened on two tickets (stacks-117, stacks-213). #196 added the hint only for a ticket that was added (has no ticket).What
check-ticket: the "outside touches" failure ends with the same hint: land the log first and check again.ticket set(touches, done-whens) as well asticket add.test/fixtures/g1/{check-ticket,merge-dry-run}.txt: the goldens carry the new wording.Tested
node --test test/components.test.mjs(the g1 goldens): 7/7 pass.🤖 Generated with Claude Code