Retabulate capture-efficiency hydro columns on the hinge basis - #67
Merged
Merged
Conversation
Co-authored-by: salhus <84348506+salhus@users.noreply.github.com>
Co-authored-by: salhus <84348506+salhus@users.noreply.github.com>
Co-authored-by: salhus <84348506+salhus@users.noreply.github.com>
Co-authored-by: salhus <84348506+salhus@users.noreply.github.com>
Co-authored-by: salhus <84348506+salhus@users.noreply.github.com>
Co-authored-by: salhus <84348506+salhus@users.noreply.github.com>
Co-authored-by: salhus <84348506+salhus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update diagnostic columns in capture efficiency CSV
Retabulate capture-efficiency hydro columns on the hinge basis
Sep 19, 2026
salhus
marked this pull request as ready for review
September 19, 2026 23:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The capture-efficiency CSVs mixed hinge-measured
P_capture_Wwith CG-referenced diagnostic hydro columns, which mademaskedbasis-wrong and allowed negative de-normalizedB55values in Python. This updates post-processing to use the hinge-referenced H5s consistently, match the C++ non-negativity clamp, and add a no-resim retabulation path for existing CSVs.Basis correction in sweep post-processing
passive_vs_optpassive_sweep.py,capture_efficiency_sweep.py, andcc_capture_efficiency_sweep.pyfromhydroData/vgoswec_*.h5tohydroData/hinged_vgoswec_*.h5.B55_Nmsrad,F_exc_Nm,P_opt_W,masked, and derivedetaon the same hinge basis asP_capture_W.Python/C++ de-normalization parity
P_optevaluation, matchingsrc/impedance.cpp.B55from the tabulation path without changing the existing mask rule.No-resimulation re-tabulation entry point
scripts/retabulate_hydro_columns.py.analysis/{passive,opt_passive}/capture_efficiency_VGM*.csv, preservesP_capture_Wand provenance fields byte-for-byte, recomputes only hydro-derived columns, and writes back with existing formatting conventions.--dry-runwith per-flap masked-row change summaries.Stage plotting from committed CSVs
scripts/plot_opt_passive_stage.py.docs/img/opt_passive_stage_per_flap.pngdocs/img/opt_passive_stage_all_flaps.pngdocs/img/opt_passive_stage_gain.pngdocs/freedecay_validation.csv(cpp_zerocross_wn_rads) for free-decayT_resmarkers and validates paired period grids before plotting ratios.Docs + regression coverage
analysis/README.mdandanalysis/BENCHMARK_NOTES.mdto describe hinge-basis tabulation and per-filerho/greads (rho=1025in hinged files vs prior CG-basis note of1000).docs/EOD_SUMMARY_2026-09-19.mdto mark the hydro-tabulation follow-up as resolved and keep the isolated resonance-adjacentP_capturedips explicitly open.B55P_capture_W