Repository navigation
Run the tests in English - #1959
Open
zolferfigueiredo wants to merge 1 commit into
Open
zolferfigueiredo wants to merge 1 commit into
zolferfigueiredo wants to merge 1 commit into
Conversation
Some tests compare against English text, such as "Middle Button" and "Button 4". On a Mac set to Italian they got the new Italian translations and failed. The scheme's test action now runs in English (en, US), in Xcode and xcodebuild alike.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1958.
Problem
On a Mac whose language isn't English, 2 tests (4 checks) fail:
MouseButtonShortcutTests.testButtonsAreNumberedFromTheLeftButtonWindowActionShortcutViewTests.testStoredMouseButtonIsShownByNameThey compare against English text ("Middle Button", "Button 4"), but the test host runs in the Mac's language. On main this already happens on Macs set to Spanish, Brazilian Portuguese, Hindi, Ukrainian or Chinese; #1957 adds Italian to that list.
Fix
The shared scheme's test action now runs in English (
language = "en",region = "US"). It applies in Xcode and inxcodebuildalike, so the tests no longer depend on the Mac's language.Tests
xcodebuild testwith no language override, on a Mac set to Italian, passes all 730 tests, including the 2 above.