allow setting zulip stream history visibility - #2732
Merged
Conversation
Dry-run check results |
marcoieni
marked this pull request as ready for review
September 3, 2026 16:34
marcoieni
requested review from
Mark-Simulacrum,
emilyalbini,
jdno and
ubiratansoares
as code owners
September 3, 2026 16:34
|
If you are changing the data structures, please make sure that the changes are not going to break serde deserialization (adding a field is fine; removing or renaming a field isn't). If you must do a breaking change to the format, make sure to coordinate it with all the users of the |
Kobzol
approved these changes
Sep 3, 2026
|
|
||
| pub(crate) fn is_empty(&self) -> bool { | ||
| self.user_group_diffs.is_empty() && self.stream_membership_diffs.is_empty() | ||
| self.user_group_diffs.is_empty() |
Member
There was a problem hiding this comment.
While we're modifying this, could you please use destructuring here, to make it harder to forget when we add new fields?
ubiratansoares
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #t-infra > ✔ DM groups in Zulip @ 💬 they asked me to modify a zulip stream visibility.
However, it's a private stream and I'm not part of it, so I can't.
I also don't want to log in with rust-lang-owner.
Merging this PR should set this field via the API.
Manual test
Unfortunately the dry run of github actions doesn't test zulip, because you cannot have a read-only Zulip token.
I tested this by running
cargo run -- sync --services zulip print-planlocally by provisioning an API key for my account.I verified that no streams that I'm in are modified.
I also verified that a stream I'm in would be updated when editing the file locally:
I had to edit the program locally to avoid errors like:
AI disclosure
I used GPT5.6-Sol with the codex harness to generate this change. I reviewed its output.