Rollup of 7 pull requests - #162284
Merged
Merged
Conversation
- Organize by "About" -> "Contributing" -> "Editing" -> "Maintaining" rather than mixing sections - Deduplicate a few lines into the guide itself - Recommend `mdbook serve` over `mdbook build` - Document `mdbook` layout and link to the upstream docs - Document sembr and that relative links must use `.md` extensions - Add a section on testing the tools in `ci/`
Fix some typos
Make README more complete and easier to follow
Dedup a bunch of information that's already on Forge
Rename LTA to CTA
This updates the rust-version file to da51146.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@da51146 Filtered ref: rust-lang/rustc-dev-guide@d9692a1 Upstream diff: rust-lang/rust@2c39ff4...da51146 This merge was created using https://github.com/rust-lang/josh-sync.
Rustc pull update
…l/mir-tyck Expand on MIR type checking.
ci: bump gha checkout action to latest
That is not all it does
fix "all x does is call ./x"
Installing cargo tools (`cargo install`) without locked dependencies exposes users to supply-chain attacks to all the dependencies of the tool (https://blog.rust-lang.org/2026/08/20/supply-chain-attack-on-arrayref/). Using `cargo install --locked` reduces this risk to a compromise of the tool itself, while using the locked and hashed version of the dependencies. I went through all `rg "cargo install"` hits in the repository and added `--locked` to all but explanatory examples (such as cargo's docs on `cargo install` itself). I validated that those tools publish functioning `Cargo.lock`s with https://gist.github.com/konstin/bcb1169c1c1120c259dca64e777a64d0.
- remove discouraging "pretty simple" in a complex chapter - mention that queries are demand-driven, not just memoized - emphasize that "query system" is a term of art (c.f. "Improper Nouns": https://siderea.dreamwidth.org/1773806.html)
touch-ups to "query system" chapter
…ocked Install cargo tools with locked dependencies
fix outdated docs about what RA config `x setup` generates
Add a central index of dev-guide reading club discussions
add some more compiler internals videos
…ethercote
Update internal docs & tests to use `!` rather than `Infallible` in relation to `Try`
- Update docs, internal comments and tests to use `!` rather than `Infallible` in `Try` situations.
- Add a custom `enum Uninhabited {}` to specific clippy tests where unintentional future divergence in handling `!` vs other uninhabited types may be a possible concern
Refs:
- Never is ~~meow~~ now rust-lang#155499
- Try: rust-lang#84277 & rust-lang/goals#654
…r=fee1-dead Clean up the AST visitor The AST visitor is macro-heavy and complicated. This PR simplifies some aspects of it. Details in individual commits. r? @fee1-dead
rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@a6da162. Created using https://github.com/rust-lang/josh-sync. r? @ghost
rustbot
added
A-attributes
Member
Author
|
@bors r+ p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Sep 4, 2026
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 71238e2 (parent) -> b924f94 (this PR) Test differencesShow 79 test diffsStage 1
Stage 2
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard b924f94129bce80f36dd9f08bb78dd5393fe196e --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (b924f94): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 2.5%, secondary 2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 3.1%, secondary -1.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 475.37s -> 480.684s (1.12%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: 71238e21fc In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
emit_ptr_va_argforva_argonsparc#160660 (c-variadic: useemit_ptr_va_argforva_argonsparc)!rather thanInfalliblein relation toTry#162174 (Update internal docs & tests to use!rather thanInfalliblein relation toTry)r? @ghost
Create a similar rollup