Skip to content

Add more splat fn type tests - #161711

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
teor2345:more-splat-fn-ptr-tests
Sep 5, 2026
Merged

Add more splat fn type tests#161711
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
teor2345:more-splat-fn-ptr-tests

Conversation

@teor2345

@teor2345 teor2345 commented Aug 25, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Tracking issue: #153629

This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR.

These tests check invalid function pointer / function type splatting, which has had recent ICE fixes (#158603, #159643).

The rustfmt::skip is required until #161709 reaches stable.

@teor2345 teor2345 self-assigned this Aug 25, 2026
@teor2345 teor2345 added A-testsuite Area: The testsuite used to check the correctness of rustc F-splat `#![feature(splat)]` https://github.com/rust-lang/rust/issues/153629 labels Aug 25, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 25, 2026
@teor2345

teor2345 commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Weird, must have hit a github outage

r? compiler

Edit: oh, I assigned myself so it didn't assign a reviewer 🤣

@rustbot rustbot assigned jieyouxu and unassigned teor2345 Sep 3, 2026
jieyouxu
jieyouxu approved these changes Sep 4, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 2b0faa2 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2026
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 4, 2026
@GuillaumeGomez
Rollup merge of rust-lang#161711 - teor2345:more-splat-fn-ptr-tests, …
34dc883 
…r=jieyouxu

Add more splat fn type tests

Tracking issue: rust-lang#153629

This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR.

These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643).

The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 4, 2026
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 4, 2026
@GuillaumeGomez
Rollup merge of rust-lang#161711 - teor2345:more-splat-fn-ptr-tests, …
12b05d2 
…r=jieyouxu

Add more splat fn type tests

Tracking issue: rust-lang#153629

This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR.

These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643).

The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 4, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 4, 2026
@bors
Auto merge of #162298 - GuillaumeGomez:rollup-LXW43Ox, r=GuillaumeGomez
cce0553 
Rollup of 25 pull requests

Successful merges:

 - #159074 ([PAC] FnAbi, llvm.ptrauth.resign and Session API change (2/8))
 - #159792 (A more readable debug map for IndexMaps)
 - #161895 (std::sys::pal::sgx: fix mismatched alloc/free alignment)
 - #161900 (bootstrap: Include feature-gated items in bootstrap tool docs)
 - #161940 (Promote `wasm32-wasip3` to a tier 2 target)
 - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`)
 - #162179 (type system const items via direct rhs)
 - #162277 (Introduce `rustc_middle::middel::resolve`)
 - #162285 (box: fixup map/try_map deallocate calls)
 - #162286 (string: don't unwind prematurely)
 - #162289 (alloc: a bunch of safety comments)
 - #162292 (Update `askama` version to `0.16.1`)
 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
 - #160906 (Suggest usize instead of placeholder type for array length constants)
 - #160936 (traits: Represent live alias arguments as bitsets)
 - #161400 (Improve diagnostics for references to closures)
 - #161656 (Suggest mutable references for FnMut closure arguments)
 - #161711 (Add more splat fn type tests)
 - #161786 (Make `tcx.def_id_partial_cmp` public)
 - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers)
 - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute)
 - #162212 (Implement `Rng` for `Box`)
 - #162246 (Fix incorrect meta span)
 - #162266 (std: fix typo)
 - #162291 (Add regression test from 1.98.1)
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 4, 2026
@GuillaumeGomez
Rollup merge of rust-lang#161711 - teor2345:more-splat-fn-ptr-tests, …
27f74fb 
…r=jieyouxu

Add more splat fn type tests

Tracking issue: rust-lang#153629

This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR.

These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643).

The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 4, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 4, 2026
@bors
Auto merge of #162300 - GuillaumeGomez:rollup-aWWJI58, r=GuillaumeGomez
443d9e9 
Rollup of 25 pull requests

Successful merges:

 - #159074 ([PAC] FnAbi, llvm.ptrauth.resign and Session API change (2/8))
 - #159792 (A more readable debug map for IndexMaps)
 - #160745 (make closures act like MaybeDangling)
 - #161895 (std::sys::pal::sgx: fix mismatched alloc/free alignment)
 - #161940 (Promote `wasm32-wasip3` to a tier 2 target)
 - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`)
 - #162179 (type system const items via direct rhs)
 - #162277 (Introduce `rustc_middle::middel::resolve`)
 - #162285 (box: fixup map/try_map deallocate calls)
 - #162286 (string: don't unwind prematurely)
 - #162289 (alloc: a bunch of safety comments)
 - #162292 (Update `askama` version to `0.16.1`)
 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
 - #160906 (Suggest usize instead of placeholder type for array length constants)
 - #160936 (traits: Represent live alias arguments as bitsets)
 - #161400 (Improve diagnostics for references to closures)
 - #161656 (Suggest mutable references for FnMut closure arguments)
 - #161711 (Add more splat fn type tests)
 - #161786 (Make `tcx.def_id_partial_cmp` public)
 - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers)
 - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute)
 - #162212 (Implement `Rng` for `Box`)
 - #162246 (Fix incorrect meta span)
 - #162266 (std: fix typo)
 - #162291 (Add regression test from 1.98.1)
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 4, 2026
@GuillaumeGomez
Rollup merge of rust-lang#161711 - teor2345:more-splat-fn-ptr-tests, …
494222f 
…r=jieyouxu

Add more splat fn type tests

Tracking issue: rust-lang#153629

This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR.

These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643).

The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 4, 2026
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 4, 2026
@GuillaumeGomez
Rollup merge of rust-lang#161711 - teor2345:more-splat-fn-ptr-tests, …
40e0da4 
…r=jieyouxu

Add more splat fn type tests

Tracking issue: rust-lang#153629

This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR.

These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643).

The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 4, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 4, 2026
@bors
Auto merge of #162308 - GuillaumeGomez:rollup-21zIph3, r=GuillaumeGomez
25c529b 
Rollup of 27 pull requests

Successful merges:

 - #159074 ([PAC] FnAbi, llvm.ptrauth.resign and Session API change (2/8))
 - #159792 (A more readable debug map for IndexMaps)
 - #160745 (make closures act like MaybeDangling)
 - #161940 (Promote `wasm32-wasip3` to a tier 2 target)
 - #162030 (Prevent `--test` to be used in `rustdoc-html` testsuite)
 - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`)
 - #162179 (type system const items via direct rhs)
 - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`)
 - #162277 (Introduce `rustc_middle::middel::resolve`)
 - #162285 (box: fixup map/try_map deallocate calls)
 - #162286 (string: don't unwind prematurely)
 - #162289 (alloc: a bunch of safety comments)
 - #162290 (abby test DSL: AliasTyOutlivesViaEnv)
 - #162292 (Update `askama` version to `0.16.1`)
 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
 - #160906 (Suggest usize instead of placeholder type for array length constants)
 - #160936 (traits: Represent live alias arguments as bitsets)
 - #161400 (Improve diagnostics for references to closures)
 - #161656 (Suggest mutable references for FnMut closure arguments)
 - #161711 (Add more splat fn type tests)
 - #161786 (Make `tcx.def_id_partial_cmp` public)
 - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers)
 - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute)
 - #162212 (Implement `Rng` for `Box`)
 - #162246 (Fix incorrect meta span)
 - #162266 (std: fix typo)
 - #162291 (Add regression test from 1.98.1)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 4, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Sep 5, 2026
@bors
Auto merge of #162310 - JonathanBrouwer:rollup-3MKPWlW, r=JonathanBro…
6d451b7 
…uwer

Rollup of 25 pull requests

Successful merges:

 - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`)
 - #162179 (type system const items via direct rhs)
 - #162255 (let people change rustc-dev-guide in-tree)
 - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`)
 - #162277 (Introduce `rustc_middle::middel::resolve`)
 - #162285 (box: fixup map/try_map deallocate calls)
 - #162286 (string: don't unwind prematurely)
 - #162289 (alloc: a bunch of safety comments)
 - #162290 (abby test DSL: AliasTyOutlivesViaEnv)
 - #162292 (Update `askama` version to `0.16.1`)
 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
 - #160906 (Suggest usize instead of placeholder type for array length constants)
 - #160936 (traits: Represent live alias arguments as bitsets)
 - #161394 (fix `is_homogeneous_aggregate`: use unit size, not total size )
 - #161400 (Improve diagnostics for references to closures)
 - #161656 (Suggest mutable references for FnMut closure arguments)
 - #161711 (Add more splat fn type tests)
 - #161786 (Make `tcx.def_id_partial_cmp` public)
 - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers)
 - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute)
 - #162212 (Implement `Rng` for `Box`)
 - #162246 (Fix incorrect meta span)
 - #162266 (std: fix typo)
 - #162291 (Add regression test from 1.98.1)
 - #162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 5, 2026
@Zalathar
Rollup merge of rust-lang#161711 - teor2345:more-splat-fn-ptr-tests, …
077e2c2 
…r=jieyouxu

Add more splat fn type tests

Tracking issue: rust-lang#153629

This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR.

These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643).

The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
@Zalathar Zalathar mentioned this pull request Sep 5, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 5, 2026
@bors
Auto merge of #162310 - JonathanBrouwer:rollup-3MKPWlW, r=JonathanBro…
0f819a1 
…uwer

Rollup of 25 pull requests

Successful merges:

 - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`)
 - #162179 (type system const items via direct rhs)
 - #162255 (let people change rustc-dev-guide in-tree)
 - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`)
 - #162277 (Introduce `rustc_middle::middel::resolve`)
 - #162285 (box: fixup map/try_map deallocate calls)
 - #162286 (string: don't unwind prematurely)
 - #162289 (alloc: a bunch of safety comments)
 - #162290 (abby test DSL: AliasTyOutlivesViaEnv)
 - #162292 (Update `askama` version to `0.16.1`)
 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
 - #160906 (Suggest usize instead of placeholder type for array length constants)
 - #160936 (traits: Represent live alias arguments as bitsets)
 - #161394 (fix `is_homogeneous_aggregate`: use unit size, not total size )
 - #161400 (Improve diagnostics for references to closures)
 - #161656 (Suggest mutable references for FnMut closure arguments)
 - #161711 (Add more splat fn type tests)
 - #161786 (Make `tcx.def_id_partial_cmp` public)
 - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers)
 - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute)
 - #162212 (Implement `Rng` for `Box`)
 - #162246 (Fix incorrect meta span)
 - #162266 (std: fix typo)
 - #162291 (Add regression test from 1.98.1)
 - #162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)
@rust-bors
rust-bors Bot merged commit 33a7b10 into rust-lang:main Sep 5, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 5, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 5, 2026
@bors
Unrolled build for #161711 in rollup 162310
875a8e0 
Rollup merge of #161711 - teor2345:more-splat-fn-ptr-tests, r=jieyouxu

Add more splat fn type tests

Tracking issue: #153629

This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR.

These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (#158603, #159643).

The `rustfmt::skip` is required until #161709 reaches stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc F-splat `#![feature(splat)]` https://github.com/rust-lang/rust/issues/153629 S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

3 participants

@teor2345 @jieyouxu @rustbot