feature-gate unsafe_no_drop_flag #22173

Activity

1. pnkfelix commented on Feb 11, 2015

   

   pnkfelix

   on Feb 11, 2015

   ContributorAuthor

   More actions

   nominating, seems 1.0 beta to me.
2. pnkfelix

   added

   I-nominated

   on Feb 11, 2015
3. pnkfelix

   self-assigned this

   on Feb 11, 2015
4. pnkfelix commented on Feb 11, 2015

   

   pnkfelix

   on Feb 11, 2015

   ContributorAuthor

   More actions

   (subtask of #5016, but gets higher priority due to (more) semantic visibility)
5. pnkfelix

   added a commit that references this issue on Feb 11, 2015

   Feature-gate the `#[unsafe_no_drop_flag]` attribute.

   ...

   This issue will close once commit f9a1087 is merged into the 'master' branch.

   f9a1087
6. bors

   closed this as completedin #22178on Feb 12, 2015
7. SSheldon commented on Feb 21, 2015

   

   SSheldon

   on Feb 21, 2015

   Contributor

   More actions

   This feature gate doesn't seem to be required as of alpha 2. The following compiles without issue:

   #[unsafe_no_drop_flag]
   struct Foo;
   
   impl Drop for Foo {
       fn drop(&mut self) {
           println!("Dropping");
       }
   }
   
   fn main() { }
8. pnkfelix

   reopened this on Feb 21, 2015
9. pnkfelix commented on Feb 25, 2015

   

   pnkfelix

   on Feb 25, 2015

   ContributorAuthor

   More actions

   it seems like PR #22364 may have accidentally have removed the gating of unsafe_no_drop_flag.

   (That's what I deserve for not including a regression test on this.)

   I think I know how to fix this. (And I will look into making sure all of the feature-gated things have tests.)
10. pnkfelix

    added a commit that references this issue on Feb 25, 2015

    Turn `unsafe_no_drop_flag` back into a gated-feature.

    ...

    This issue will close once commit 5d7e283 is merged into the 'master' branch.

    5d7e283
11. Manishearth

    added a commit that references this issue on Feb 25, 2015

    Rollup merge of rust-lang#22787 - pnkfelix:reenable-gate-for-unsafe_n…

    ...

    This issue will close once commit f164254 is merged into the 'master' branch.

    f164254
12. bors

    closed this as completedin #22787on Feb 25, 2015