Skip to content

use mise to install CLI tools / manage their versions - #3495

Merged
syphar merged 2 commits into
rust-lang:mainfrom
syphar:mise-tool
Sep 3, 2026
Merged

use mise to install CLI tools / manage their versions#3495
syphar merged 2 commits into
rust-lang:mainfrom
syphar:mise-tool

Conversation

@syphar

@syphar syphar commented Sep 3, 2026

Copy link
Copy Markdown
Member

mise got recommended to me multiple times over the last months, and having used it on my machine, I like it quite much.

It's much easier than the justfile _ensure_cargo_install, also covers other tools like actionlint, deno etc.

Also, we'll use the same versions, across CI & locally.

One caveat with the way I'm changing the gh workflows: there is no artifact caching any more. Though I don't thing that's a huge issue for npm, deno etc.

@syphar syphar self-assigned this Sep 3, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Sep 3, 2026
@syphar syphar changed the title WIP: try mise to install CLI tools / manage their versions try mise to install CLI tools / manage their versions Sep 3, 2026
@syphar
syphar marked this pull request as ready for review September 3, 2026 06:50
@syphar
syphar requested a review from a team as a code owner September 3, 2026 06:50
@syphar

syphar commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned syphar Sep 3, 2026
@syphar syphar changed the title try mise to install CLI tools / manage their versions use mise to install CLI tools / manage their versions Sep 3, 2026
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/commit-sqlx-changes.yml Outdated
Comment thread .github/workflows/dev-guide.yml Outdated
Comment thread .github/workflows/docker.yml Outdated
@rustbot

rustbot commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Thinking out loud: we added just to simplify development, and now we added mise to simplify just files. It's starting to be a lot of extra development tools for something we could do with cargo commands, no? ^^'

@syphar

syphar commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

Thinking out loud: we added just to simplify development, and now we added mise to simplify just files. It's starting to be a lot of extra development tools for something we could do with cargo commands, no? ^^'

valid question of course.

How exactly would that look like with the tools we install via mise now?

( I would like to prevent that users have to install everything themselves)

@GuillaumeGomez

Copy link
Copy Markdown
Member

It'd require to have a bigger build system. We'd run command like cargo lint and it'd run a lint.rs binary in the repository which would have the whole logic implemented inside etc. That's how rustc, clippy and rustc_codegen_gcc (for the ones I know of) are doing things. Big disadvantage: it requires more code and is likely less flexible. Advantage: no extra tools needed.

@syphar

syphar commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

but that doesn't solve deno and others? or hadolint I want to add, or actionlint, or node, right?

@GuillaumeGomez

Copy link
Copy Markdown
Member

No it doesn't. But at least, just and mise would not be needed anymore. In any case, not a blocker from me, just raising an eyebrow and potential future concerns.

@syphar

syphar commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

For now I hope that this will solve all tool-install issues.

Until now it then was super annoying, every dev has to locally install, freeze the version somehow, and in CI the same.

Mise seems to solve both sides.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Then sounds good to me.

@syphar
syphar merged commit 00e1f6b into rust-lang:main Sep 3, 2026
10 checks passed
@syphar
syphar deleted the mise-tool branch September 3, 2026 14:58
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Sep 3, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants