WIP: refactor builder / rustwide integration - #3480
Draft
syphar wants to merge 192 commits into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
syphar
commented
Sep 8, 2026
| @@ -0,0 +1,75 @@ | |||
| #![allow(dead_code)] | |||
Member
Author
There was a problem hiding this comment.
how to prevent this allow?
but still make it usable in integration tests?
Member
Author
There was a problem hiding this comment.
( no review requested yet ;) )
I'll try that , but for integration tests, does this still work?
Member
Author
There was a problem hiding this comment.
I'll find a way, this is more a note to myself going through the WIP :)
syphar
commented
Sep 8, 2026
|
|
||
| pub fn init_logging() { | ||
| INIT_LOGGING.call_once(|| { | ||
| tracing_subscriber::fmt() |
Member
Author
There was a problem hiding this comment.
why separate logging config ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
docs_rs_rustwide, check test coveragerustwide_builder, check test coverage