Skip to content

WIP: refactor builder / rustwide integration - #3480

Draft
syphar wants to merge 192 commits into
rust-lang:mainfrom
syphar:builder-ci
Draft

WIP: refactor builder / rustwide integration #3480
syphar wants to merge 192 commits into
rust-lang:mainfrom
syphar:builder-ci

Conversation

@syphar

@syphar syphar commented Aug 27, 2026

Copy link
Copy Markdown
Member

TODO:

  • manually test build-server build (see if json, docs, build logs, are all uploaded)
  • manually test build-cli build
  • clean up log output (tracing fields) generally around the build
  • in case of build errors in the doc-builds, I want to see them
  • clean up docs_rs_rustwide , check test coverage
  • clean up rustwide_builder, check test coverage
  • builder cli, print stats in the end, related to limits (so, per build (target / json / cov / html) we show mem, time)

@rustbot

This comment has been minimized.

@@ -0,0 +1,75 @@
#![allow(dead_code)]

@syphar syphar Sep 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to prevent this allow?

but still make it usable in integration tests?

View changes since the review

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cfg(test)?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( no review requested yet ;) )

I'll try that , but for integration tests, does this still work?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll find a way, this is more a note to myself going through the WIP :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dully noted. :)


pub fn init_logging() {
INIT_LOGGING.call_once(|| {
tracing_subscriber::fmt()

@syphar syphar Sep 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why separate logging config ?

View changes since the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants