Clarify string slice parameter wording - #4827
Open
Rayan-and-beyond wants to merge 1 commit into
Open
Rayan-and-beyond wants to merge 1 commit into
Rayan-and-beyond wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4816.
Clarifies that the comparison is between a parameter typed as
&strand one typed as&String. The surrounding text already explains that deref coercion lets the&strparameter accept both&Stringand&strvalues.Validation:
git diff --checkdprint check src/ch04-03-slices.mdreports one existing formatting mismatch at line 28 (*part*vs_part_); the same failure reproduces on an untouchedmaincopy, and this change does not touch that line.