Skip to content

Deprecate while_some() - #1126

Merged
phimuemue merged 4 commits into
rust-itertools:masterfrom
ronnodas:while-some-deprecate
Sep 5, 2026
Merged

Deprecate while_some()#1126
phimuemue merged 4 commits into
rust-itertools:masterfrom
ronnodas:while-some-deprecate

Conversation

@ronnodas

@ronnodas ronnodas commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Closes #1120. I guessed the next breaking release for the since field, some guidance about this would be helpful.

@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.92%. Comparing base (6814180) to head (2d87baf).
⚠️ Report is 214 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
- Coverage   94.38%   93.92%   -0.47%     
==========================================
  Files          48       52       +4     
  Lines        6665     6681      +16     
==========================================
- Hits         6291     6275      -16     
- Misses        374      406      +32     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phimuemue
phimuemue enabled auto-merge September 5, 2026 05:28
@phimuemue
phimuemue added this pull request to the merge queue Sep 5, 2026
Merged via the queue into rust-itertools:master with commit 99a67e7 Sep 5, 2026
8 of 14 checks passed
@ronnodas
ronnodas deleted the while-some-deprecate branch September 5, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate while_some() in favor of map_while()

2 participants