Re-run the calls of Struct.[] when its builtin is set or removed - #498
Merged
Merged
Conversation
Struct.[] is a builtin set on the method entity rather than a method definition, and assigning a builtin does not notify the calls that depend on the entity. After editing `Pt = Struct.new(:x, :y)` into `Pt = Data.define(:x, :y)`, `Pt[1, 2]` still used the removed builtin and reported "wrong number of arguments (2 for 0)" instead of an undefined method. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mame
enabled auto-merge (rebase)
September 28, 2026 13:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #491.
Struct.[]is now a builtin set on the method entity rather than a method definition. Unlike adding or removing a definition, setting or removing a builtin does not notify the calls that depend on it. So after an edit like this,Pt[1, 2]kept using the removed builtin:This re-runs the calls when the builtin is set or removed.