Analyze a pattern guard after the pattern binds its variables - #495
Merged
Merged
Conversation
IfPatternNode installed the guard before the guarded pattern, so a variable bound by the pattern was still nil in the guard, and a common guard like `in [x] if x.even?` reported "undefined method: nil#even?". Ruby evaluates the guard after the pattern matches, so install the pattern first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while reviewing #483.
A guard was analyzed before the guarded pattern, so a variable bound by the pattern was still nil in the guard:
Ruby evaluates the guard after the pattern matches, so this installs the pattern first. The same applies to
unlessguards.