Update mmtk-core and remove LOS workaround - #117
Merged
Merged
Conversation
There was a bug in mmtk-core that caused `is_live()` and `is_reachable()` to return wrong results for objects in the large object space. The function `object_survives_current_gc` was introduced to workaround the bug. The bug has been fixed in mmtk-core. We bump the mmtk-core dependency revision, and remove the workaround. We now simply use `object.is_reachable()` to test if an object will survive the current GC. See: mmtk/mmtk-core#1594
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in mmtk-core that caused
is_live()andis_reachable()to return wrong results for objects in the large object space. The functionobject_survives_current_gcwas introduced to workaround the bug.The bug has been fixed in mmtk-core. We bump the mmtk-core dependency revision, and remove the workaround. We now simply use
object.is_reachable()to test if an object will survive the current GC.See: mmtk/mmtk-core#1594