Add processor_count and processor_quota APIs - #98
Open
samuel-williams-shopify wants to merge 1 commit into
Open
samuel-williams-shopify wants to merge 1 commit into
samuel-williams-shopify wants to merge 1 commit into
Conversation
Assisted-By: devx/874cdf9e-3541-4d85-9ae8-b4ebb7e4db80
Author
|
After experimenting with this code, I wonder if we shouldn't bother supporting cgroups v1. It's more complexity and every system where it's relevant is using cgroups v2 now. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two processor-capacity APIs without changing the behavior of
Etc.nprocessors:Etc.processor_countis an alias forEtc.nprocessorsand returns anInteger.Etc.processor_quotareturns the usable processor capacity as aFloat. On Linux it accounts for cgroup v1/v2 CPU bandwidth quotas, capped by the affinity-aware processor count; otherwise it falls back toEtc.processor_count.to_f.The cgroup lookup resolves the process membership through
/proc/self/cgroupand/proc/self/mountinfo, considers limits inherited from ancestor cgroups, and falls back safely when cgroup information is unavailable or malformed.This implements the separate fractional API discussed in Feature #21797, while preserving
Etc.nprocessorscompatibility, and is an alternative API shape to #75.Tests cover the aliases and return types, cgroup v1 and v2 fractional quotas, inherited limits, unlimited/malformed values, escaped mount paths, and Ractor use.
Tested with: