Etc.uname: Report the actual Windows version - #104
Merged
Merged
Conversation
GetVersionEx reports 6.2.9200 on Windows 8.1 and later unless the manifest of the executable declares them as supported, and ruby.manifest does not. RtlGetVersion is not affected by the manifest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows 8.1 and later,
Etc.uname[:release]returned6.2.9200becauseGetVersionExWreports Windows 8 unless the executable's manifest declares newer versions as supported, and Ruby's manifest does not. It now callsRtlGetVersion, which ignores the manifest. The newtest_uname_release_on_windowscompares the result withcmd.exe /c ver.This landed in ruby/ruby first as ruby/ruby@f6ff9e7d02 (ruby/ruby#19074). I brought it here unchanged.
The CI here does not run on Windows, so I checked on x64 mswin with Windows 11 that
rake compile testpasses on Ruby 4.1.0dev and 3.3.12, and thatEtc.uname[:release]changes from6.2.9200to10.0.26200. I did not check the mingw build.Generated with Claude Code