Add ext/etc/depend - #101
Merged
Merged
Conversation
`tool/sync_default_gems.rb` copies this directory wholesale, so the rule that builds `constdefs.h` has to live here or ruby/ruby loses it. Generated with `ruby ext/etc/extconf.rb --update-depend`. https://bugs.ruby-lang.org/issues/22206 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext/etchas nodepend, soruby tool/sync_default_gems.rb etcdeletes the one ruby/ruby carries. Misc #22206 has each default gem keep its own dependency file, and the whole-tree sync removes each mapped directory before copying the upstream files in. What goes with it is the handwritten rule that buildsconstdefs.h.This adds the file as
ruby ext/etc/extconf.rb --update-dependgenerates it. Root detection stops at this repository's.git, so the rules name onlyetc.candconstdefs.hand no installed Ruby header.minimize_dependencieson the ruby/ruby side reduces the autogenerated block toetc.o: etc.c, which matches the file there today byte for byte.The
constdefs.hrule is redundant for this repository, since theRakefilealready generates that header, but it has to travel with the file for ruby/ruby's sake.Generated with Claude Code