Repository navigation
test(vscode): raise lint E2E mocha default timeout - #102
Merged
Merged
Conversation
The lint E2E runner used Mocha's 2000ms default, so hooks doing real workspace I/O without their own this.timeout() could time out on Windows CI runners (the workspace document router suiteSetup). Use the same 120s default the Rstest runners use.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The lint E2E runner (
packages/vscode/e2e/lint/runSuite.ts) created Mocha without atimeout, so every hook and test that does not callthis.timeout()ran under Mocha's 2000ms default. On Windows CI theworkspace document routersuite'ssuiteSetup(create a directory, write a file, open it) exceeded that, and itssuiteTeardownthen failed on the never-assigneddocument.This sets the runner's default timeout to 120s, matching the Rstest runners (
e2e/runSuite.ts,e2e/rstest/suite/index.ts). Tests with an explicitthis.timeout()keep their own values. The ported test file is unchanged; the harness divergence is recorded in the runner's adaptation list and inpackages/vscode/AGENTS.mdas an offer-back item.Related Links
Checklist