Conversation
CUDA moves from `[deps]` to `[weakdeps]` behind a new `CUDAExt`, so installing and loading ParallelMCMC no longer drags the CUDA stack onto machines that cannot use it. `using ParallelMCMC` alone now leaves CUDA unloaded. The samplers were already array-type-agnostic everywhere but the random fills — MALA's normal noise and DEER's Rademacher probes — which cannot be written into device memory one element at a time. Those four `isa CuArray` checks all asked the same question, so they collapse into one trait, `needs_host_staging(x)`, defaulting to `false`. `_rademacher!` loses its two `CuArray` dispatches for a trait branch in the generic method. The extension is a single method setting that trait for `CuArray`, which also drops the NVIDIA-only assumption: an AMDGPU or Metal user adds one method rather than waiting on another extension.
CUDA moves from `[deps]` to `[weakdeps]` behind a new `CUDAExt`, so installing and loading ParallelMCMC no longer drags the CUDA stack onto machines that cannot use it. `using ParallelMCMC` alone now leaves CUDA unloaded. The samplers were already array-type-agnostic everywhere but the random fills — MALA's normal noise and DEER's Rademacher probes — which cannot be written into device memory one element at a time. Those four `isa CuArray` checks all asked the same question, so they collapse into one trait, `needs_host_staging(x)`, defaulting to `false`. `_rademacher!` loses its two `CuArray` dispatches for a trait branch in the generic method. The extension is a single method setting that trait for `CuArray`, which also drops the NVIDIA-only assumption: an AMDGPU or Metal user adds one method rather than waiting on another extension.
…MC.jl into cuda-extension # Conflicts: # CHANGELOG.md # docs/src/15-gpu.md # docs/src/95-reference.md # ext/CUDAExt.jl # src/DEER/DEER.jl # src/ParallelMCMC.jl # test/test-CUDA-Extension.jl
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start of a text refresh. Goal for this is to rewrite the entire set of docs/docstrings/etc. all humanized. Right now It's like 55:45 human:robot text. I'd like that to be at a minimum 75:25 for the sake of readability.
Resolves #70