Repository navigation
Conversation
Testo, the new test runner, needs PHP 8.2 or newer; PHP 8.0 and 8.1 are end-of-life. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
build: allow vimeo/psalm ^6 || ^7 PHPUnit mocks moved to Mockery, since Double needs PHP 8.3. vimeo/psalm ^5 does not install on PHP 8.4+, so it is raised to keep the Testo job on the full 8.2-8.6 matrix; psalm 6 reports new errors in src, which are left for a separate change. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^8.2); README requirements updated.phpunit.xmlare removed;composer testrunsvendor/bin/testo.testo/bridge-mockeryverifies expectations after each test). Double was not an option, since it needs PHP 8.3.spiral/gh-actions/.github/workflows/testo.yml(see feat(testo): test PHP 8.2-8.6 by default, add test-server input spiral/gh-actions#10) withlowest/highestdependencies, replacing the formerprefer-lowest/prefer-stablematrix.Review notes
vimeo/psalmis raised to^6 || ^7so the Testo job runs on the full PHP 8.2–8.6 matrix. Psalm 6 reports 16 new errors insrc(MissingOverrideAttribute,RiskyTruthyFalsyComparison, …), left for a separate PR.InstalledTest::getVersionFromEnv()andgetVersionFromConsoleCommand()lack thetestprefix, so PHPUnit never ran them; they stay unmarked under Testo too, to keep the port 1:1.