Repository navigation
Conversation
Assisted-By: Claude Opus 5.5
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. 鈿欙笍 Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Tests only, no production code changes.
create()without optional arguments sends the documented defaults (1 process, no exec timeout, 30 s restart delay, 5 s stop timeout, empty env).create(),restart()andterminate()returnfalsewhen RoadRunner answersok: false.Exception\ServiceExceptionwith tabs and newlines flattened to spaces, the original code and the RPC exception as previous;statuses()wraps them too.list()andstatuses()with nothing to report return[]; a process without an error status gets'error' => null.The three uncovered statements are the
return falseafterhandleError()increate(),restart()andterminate():handleError()returnsnever, so they are unreachable. Theassert()argument checks increate()are not tested, since they depend onzend.assertions.Checklist
vendor/bin/testolocally on PHP 8.4 with Xdebug coverage: 18 tests passed (9 before)