Skip to content

refactor: mark overriding methods with #[\Override] - #20

Merged
roxblnfk merged 1 commit into
1.xfrom
static-analysis
Oct 9, 2026
Merged

roxblnfk merged 1 commit into
1.xfrom
static-analysis

Conversation

@roxblnfk

@roxblnfk roxblnfk commented Oct 9, 2026

Copy link
Copy Markdown
Member
Q A
Bugfix? ❌
Breaks BC? ❌
New feature? ❌
Issues —
  • Methods that implement an interface method carry #[\Override], and Psalm now reports MissingOverrideAttribute instead of suppressing it. PHP 8.2 ignores the attribute, so no polyfill is needed.

  • The InvalidOperand suppression is gone too: an int|float TTL is cast to float before it is scaled to microseconds. The redundant round() on the integral DateInterval product is dropped. Behaviour is unchanged.

  • psalm.xml has no issue handlers left.

  • How was this tested:

    • Psalm at error level 1 reports no errors locally
    • Testo: 56 passed, 2 skipped, the same as on 1.x
    • Infection: covered MSI 94% (2 equivalent escaped mutants), above the 90% gate

Psalm now checks `MissingOverrideAttribute` and `InvalidOperand` instead of suppressing them; the attribute is harmless on PHP 8.2. The TTL is converted to float before scaling, which keeps the result for every realistic TTL. The redundant `round()` on the integral DateInterval product is gone, so Infection no longer reports it as equivalent escaped mutants.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
@roxblnfk
roxblnfk requested a review from a team October 9, 2026 19:58
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e77b71f6-a9e0-4915-b9e9-d9f75eda69f3

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@roxblnfk
roxblnfk merged commit c531c3e into 1.x Oct 9, 2026
15 checks passed
@roxblnfk
roxblnfk deleted the static-analysis branch October 9, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant