Repository navigation
refactor: mark overriding methods with #[\Override] - #20
Merged
Merged
Conversation
Psalm now checks `MissingOverrideAttribute` and `InvalidOperand` instead of suppressing them; the attribute is harmless on PHP 8.2. The TTL is converted to float before scaling, which keeps the result for every realistic TTL. The redundant `round()` on the integral DateInterval product is gone, so Infection no longer reports it as equivalent escaped mutants. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Methods that implement an interface method carry
#[\Override], and Psalm now reportsMissingOverrideAttributeinstead of suppressing it. PHP 8.2 ignores the attribute, so no polyfill is needed.The
InvalidOperandsuppression is gone too: anint|floatTTL is cast to float before it is scaled to microseconds. The redundantround()on the integralDateIntervalproduct is dropped. Behaviour is unchanged.psalm.xmlhas no issue handlers left.How was this tested:
1.x