Repository navigation
ci: run mutation tests with Infection - #19
Merged
Merged
Conversation
test: check that TTLs are rounded to the nearest microsecond Infection is installed in the workflow rather than from the phar or require-dev: the 0.35.6 phar's Testo adapter calls the unscoped IncludeInterceptor, and Infection needs PHP 8.3+ while the package supports 8.2. The three remaining escaped mutants are equivalent: rounding or casting the already integral DateInterval product. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds mutation testing with Infection on top of the Testo suite.
Mutation Testsworkflow runs on PRs and pushes to1.x(PHP 8.4, Xdebug,zend.assertions=1) with--min-msi=90 --min-covered-msi=90; pushes to1.xsend the report to the Stryker dashboard, and the README gets its badge.floor/ceilmutants). The 3 escaped mutants are equivalent:round/floor/ceiland the(int)cast on the already integralDateIntervalproduct.Review notes
Infection is installed with
composer requirein the workflow, not from the phar: the Testo adapter bundled in the 0.35.6 phar writes a bootstrap calling the unscoped\Infection\StreamWrapper\IncludeInterceptor, while the phar only contains the scoped class, so every mutant ends as an error.It is not in
require-devbecause Infection ≥ 0.33 needs PHP 8.3+, and the package supports 8.2.How was this tested: