Skip to content

Add margins around top-level tables - #218

Merged
eric-schneider merged 1 commit into
mainfrom
t1-table-spacing
Nov 18, 2026
Merged

eric-schneider merged 1 commit into
mainfrom
t1-table-spacing

Conversation

@eric-schneider

@eric-schneider eric-schneider commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Tables that sit directly in article.doc, which happens on pages without sections, get no top margin, because the table margin rule in doc.css only matches tables whose parent is inside .doc. Such a table sits flush against the block above it, or only 16 px below the page title.

This adds the two selectors from upstream's 64fc443 in antora-ui-default, so these tables, and the block after each one, get the same 24 px top margin as every other table.

Size changes: site.css grows by 46 bytes; site.js and the fonts don't change.

docs-ui's table margin rule only matches a table whose parent sits
inside .doc. On a page without sections, a table is a direct child of
article.doc, so neither the table nor the block after it gets the
24 px top margin that other tables get. In production, 215 such tables
on 138 pages sit flush against the block above, and 198 follow the
page title at 16 px (F01).

Add the two selectors from upstream's 64fc443 in antora-ui-default,
"add margin top to tables that are direct children of article.doc",
so these tables get the same spacing as all others.
@eric-schneider eric-schneider self-assigned this Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

UI bundle preview build successful! ✅
Deploying bundle preview.
Deploy successful! View preview

@plpesvc-ds

plpesvc-ds commented Nov 18, 2026 •

Copy link
Copy Markdown

Build successful! ✅
Deploying draft.
Deploy successful! View draft

@eric-schneider
eric-schneider merged commit 753b9ed into main Nov 18, 2026
2 checks passed
@eric-schneider
eric-schneider deleted the t1-table-spacing branch November 18, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants