Repository navigation
Add margins around top-level tables - #218
Merged
Merged
Conversation
docs-ui's table margin rule only matches a table whose parent sits inside .doc. On a page without sections, a table is a direct child of article.doc, so neither the table nor the block after it gets the 24 px top margin that other tables get. In production, 215 such tables on 138 pages sit flush against the block above, and 198 follow the page title at 16 px (F01). Add the two selectors from upstream's 64fc443 in antora-ui-default, "add margin top to tables that are direct children of article.doc", so these tables get the same spacing as all others.
Contributor
|
UI bundle preview build successful! ✅ |
|
Build successful! ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tables that sit directly in
article.doc, which happens on pages without sections, get no top margin, because the table margin rule indoc.cssonly matches tables whose parent is inside.doc. Such a table sits flush against the block above it, or only 16 px below the page title.This adds the two selectors from upstream's 64fc443 in antora-ui-default, so these tables, and the block after each one, get the same 24 px top margin as every other table.
Size changes:
site.cssgrows by 46 bytes;site.jsand the fonts don't change.