Repository navigation
Create BaseTextTableRender with reusable text table code - #18
Merged
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RATIONALE
Refactor the
TextTableRenderinto a base class (BaseTextTableRender) and leave text-table specific things in place. This makes room for another render class to re-use these elements. TheTableGlyphsprovide for the box parameters (for the lines) the characters provide left, fill, junction, and right values that define the lines of a table.CHANGES
Refactor
TextTableRenderto pull out reusable pieces toBaseTextTableRender. Here are some of the "highlights":pad()- appropriately horizontally pad cell texttextRow()- creates line of text for a singlerowobjectrule()- creates table separator line using the providedglyphs.caption()- formats caption text (if any)sharesLeadingCells()- when removing redundant, this sets matchedcurrentRowcells to empty strings.