Conversation
rfresh2
reviewed
Sep 23, 2026
| isEating = false; | ||
| // we completed eating successfully | ||
| constantTimer.reset(); | ||
| delay = 0; |
Owner
There was a problem hiding this comment.
remove, delay is already known to be 0
| // we completed eating successfully | ||
| constantTimer.reset(); | ||
| delay = 0; | ||
| INVENTORY.submit(InventoryActionRequest.noAction(this, getPriority())); |
Owner
There was a problem hiding this comment.
remove, no need to block inv actions at this point
| INVENTORY.submit(InventoryActionRequest.noAction(this, getPriority())); | ||
| return; | ||
| } | ||
| isEating = false; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When \AutoOmen\ finishes drinking an ominous bottle, it immediately starts drinking a second one on the same tick, consuming two bottles per cycle instead of one.
Root cause
In \AutoOmen.handleClientTick(), the drink-completion branch (\if (isEating)) only reset the constant timer, then fell through to \doInventoryActionsV2(). The bottle was still equipped, so it returned \ITEM_IN_HAND\ and re-invoked \startEating(), beginning another drink right away.
Fix
Finalize the drink state and return early after a completed drink:
oAction\ inventory request so the inventory executor can settle
eturn\ to avoid falling through and starting a second drink
Notes
oAction\ submit on the completion path are defensive no-ops in the normal flow but keep the state consistent.