Skip to content

test: verify HTTP/2 per-message flushing - #1542

Merged
jlouvel merged 1 commit into
3.0from
test/rpc-c4-http2-flush
Oct 20, 2026
Merged

jlouvel merged 1 commit into
3.0from
test/rpc-c4-http2-flush

Conversation

@jlouvel

@jlouvel jlouvel commented Oct 18, 2026

Copy link
Copy Markdown
Collaborator

Implements C4 on top of C3 (#1541).

The Netty ChannelOutputStream in #1538 already flushes buffered bytes with writeAndFlush. This PR adds contract tests for both HTTP/2 directions: a request reader receives the first flushed DATA before the upload finishes, and a response reader receives the first flushed DATA before the representation finishes. No production change was needed because the underlying flush behavior is already present.

Validation: mvnw -B -pl org.restlet -Dtest=Http2FlushTestCase,Http2FullDuplexTestCase,Http2CancellationTestCase,HttpTrailersTestCase test (C4 tests pass; cancellation test has since been strengthened and passes independently).

@jlouvel jlouvel self-assigned this Oct 18, 2026
@jlouvel
jlouvel requested a review from thboileau October 18, 2026 14:49
@jlouvel
jlouvel force-pushed the test/rpc-c4-http2-flush branch from bd18967 to 8b7e3d7 Compare October 18, 2026 14:57
@jlouvel
jlouvel added this pull request to stack #1548 October 20, 2026 12:42
@jlouvel
jlouvel force-pushed the test/rpc-c4-http2-flush branch 3 times, most recently from 795cf2c to dacf132 Compare October 20, 2026 13:31
Base automatically changed from feat/rpc-c3-cancellation to 3.0 October 20, 2026 13:31
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Jerome Louvel <374450+jlouvel@users.noreply.github.com>
@jlouvel
jlouvel force-pushed the test/rpc-c4-http2-flush branch from dacf132 to c4a534f Compare October 20, 2026 13:31
@jlouvel
jlouvel merged commit 3acd2d1 into 3.0 Oct 20, 2026
@jlouvel
jlouvel deleted the test/rpc-c4-http2-flush branch October 20, 2026 13:32
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants