Repository navigation
fix: keep empty contact lists when merging multi-file responses - #106
Conversation
[Medium impact] This PR appears safe to merge; no actionable issues were found. Reviews (1) · Last reviewed commit: "fix: keep empty contact lists when mergi..." · Reviewed by Greptile |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 30 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
When the first file's response had a null party or contact, merging the next response created an empty object and skipped its `[]` email/phone lists. `contact.email` then read as None and raised "can only concatenate list (not "NoneType") to list" in set_details. - ResponseMerger: fill a missing/None key with an empty source value - add get_party_contact to collect emails/phones null-safely
b9899c4 to
64e3a49
Compare
When the first file's response had a null party or contact, merging the next response created an empty object and skipped its
[]email/phone lists.contact.emailthen read as None and raised "can only concatenate list (not "NoneType") to list" in set_details.