Repository navigation
Scene Mutes 0.1.0-experimental for Analog Rytm MKII (OS 1.74) - #1351
Open
Iced-Cream wants to merge 7 commits into
Open
Iced-Cream wants to merge 7 commits into
Iced-Cream wants to merge 7 commits into
Conversation
…og Rytm MKII) Port of rytm-mods-src 0018-scene-mutes (MrScruff) to a Modwerk module on OS 1.74 and core-ar2 0.7, with its own six sites. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…builder Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Iced-Cream
marked this pull request as ready for review
November 8, 2026 23:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scene Mutes 0.1.0-experimental for Analog Rytm MKII (OS 1.74)
MrScruff's rytm-mods
0018-scene-mutes, from rytm-mods-src (cd4ded4), with his code unchanged and its addresses moved from OS 1.73 to 1.74. In scene edit, FUNC + T1..T13 builds the edited scene's mute mask (T13 is FX), and the trig keys show it while FUNC is held. Engaging a marked scene sets the mutes; an unmarked scene, or none, puts back the mutes from before.<CLEAR>and<CLEAR ALL>also drop the masks. Categorysystem, core-ar2 0.7, no dependency on another module, 6 sites, 1002 bytes of.runand 6 of.bss.What this adds:
sdk/analog-rytm-mkii/modules/scene-mutes/(source,build.json, manifest, README, TESTING, licence, thumbnail), release notes, author-hardware evidence, a rytm-emu capture with itsmedia/capture.json, the source-only packagesdk/imports/packages/scene-mutes/scene-mutes-0.1.0-experimental-os1.74.elemod, its recordssdk/imports/scene-mutes-2026-11-08.jsonandsdk/imports/elekloader-scene-mutes-2026-11-08.json, the vendored catalogue copy and a verification record.Sites: SceneEditView's key and LED vtable slots (
ptr), its two clear actions (byteswith a reloc, so no stock opcode is kept), andjmpdetours at the entries of the scene-engage and track-mute routines. None is a core, base or other module's site.Storage: the masks live in the current kit's record in the stored project (
+0x832..+0x841,+0x902..+0x90c), bytes stock leaves alone. core-ar2's kit storage uses+0x816..+0x822of the same record, so they don't overlap, and the module declares no core storage.How it was checked:
m68k-linux-gnu-asassembles the source;scripts/build-elemod-packages.mjs+package-elemod-recipe.mjsbuild the package (the same toolchain reproduces env-reset-amp's committed package byte for byte with--check).tools/port_os.pyMapper moves all 19 addresses the module names to the ones it uses, and all six site guards match 1.74.npm run module:doctor -- scene-mutes: all green.npm run pr:ready: Ready. The package is vendored withnpm run elekloader:update -- --overlay sdk/imports/elekloader-scene-mutes-2026-11-08.json; record indocs/verification/2026-11-08-rytm-scene-mutes-library.md.Hardware (T210, 2026-11-08, OS 1.74, build SMH1 = base for core-ar2 0.7 + analoghealth 1.3 harness + this module): with scene 1 engaged BD and SD went silent while RS and CH played; a hand mute of CH while engaged stayed after disengaging, when BD and SD came back; the mask and the hand mute survived a power cycle;
<CLEAR>dropped the mask. CPU 74 to 82 %, heap flat. Not tested on a unit:<CLEAR ALL>, scene engage by CC 92, NRPN or Overbridge, kit changes. The author listened to the takes; evidence tierauthor-hardware(evidence/hardware-testing.json).What the guides lacked: nothing.