Conversation
Blocks queued to the main queue captured `this`, so a swapchain destroyed before an asynchronous size or refresh-rate update ran left the block reading freed memory (objc_msgSend crash in updateWindowAttributesInternal). Keep the cached state in a shared_ptr and capture it with the NSWindow instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
AI-generated contributions are not accepted, especially ones with Claude as the co-author. No copyright will be given to Anthropic in any of my projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocks queued to the main queue captured
this, so a swapchain destroyedbefore an asynchronous size or refresh-rate update ran left the block reading
freed memory (objc_msgSend crash in updateWindowAttributesInternal). Keep the
cached state in a shared_ptr and capture it with the NSWindow instead.
Testing
main;-fsyntax-onlycompile of the changed sources on arm64 macOS againstmainpasses.🤖 Generated with Claude Code