Conversation
…lear state setFramebuffer ended the active render encoder even when the same framebuffer was rebound. Renderers that set the framebuffer before every draw started a new render pass per draw, which dominated encoding time on Apple GPUs. Return early when the target is unchanged, an encoder is open and no clears are pending, matching the Vulkan backend's guard. Partial color clears created a new depth-stencil state on every clear and never released it; use a device-lifetime clearColorDepthState instead. Both partial clear paths now compute the clear pipeline key from the framebuffer formats and look up the cached pipeline before allocating a render pipeline descriptor, which is only built on a cache miss. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
AI-generated contributions are not accepted, especially ones with Claude as the co-author. No copyright will be given to Anthropic in any of my projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setFramebuffer ended the active render encoder even when the same
framebuffer was rebound. Renderers that set the framebuffer before every
draw started a new render pass per draw, which dominated encoding time on
Apple GPUs. Return early when the target is unchanged, an encoder is open
and no clears are pending, matching the Vulkan backend's guard.
Partial color clears created a new depth-stencil state on every clear and
never released it; use a device-lifetime clearColorDepthState instead.
Both partial clear paths now compute the clear pipeline key from the
framebuffer formats and look up the cached pipeline before allocating a
render pipeline descriptor, which is only built on a cache miss.
Testing
main;-fsyntax-onlycompile of the changed sources on arm64 macOS againstmainpasses.🤖 Generated with Claude Code